[Bug 1694159] Re: libvirt-bin dropped conffiles but never cleaned them up on disk

[ChristianEhrhardt]

Most of this should have not existed or cleaned up long ago :-/.
But it wasn't, so we now have to decide how to distribute potential fallout the best way for end-users.
We need to "protect" the new files which already exist since yakkety, so we can't just move over the old ones.
There by since in most cases both (old&new) files exist, we can only rm_conffile the no more active ones to ensure users do not accidentially edit those without effect.

Also for SRUs this could cause all sorts of regressions if people fixed up things to properly consider their old configs.
Therefore for now only considering a clean-up in artful and keeping in the back of our mind if e.g. bugs come along like "I change A.conf and nothing happens".
Also the SRU'ability can be decided later on if needed.
I already had noted 79 todo's for the next merge related to cleanup of our Delta, why not a few more around dpkg-maintscript-helper :-/

For now I checked on the files that I found missing (Note: more than
initially reported and uncovering potential Debian issues on top):

1. Files Ubuntu failed to properly migrate and now should be removed:
 /etc/init/libvirt-bin.conf
  => upstart gone no more needed

 /etc/dnsmasq.d/libvirt-bin
 /etc/dnsmasq.d-available/libvirt-bin bbf7e62e130a4cb7b6db7c4260883a68 obsolete
  => now /etc/dnsmasq.d-available/libvirt-daemon
     Old file is superfluous X->Y

 /etc/cron.daily/libvirt-bin
  => is now /etc/cron.daily/libvirt-daemon-system
     Old file is superfluous X->Y

 /etc/default/libvirt-bin 619ef67a86531f89f4cf45efde87cb82 obsolete
  => now /etc/default/libvirtd (with changed behavior e.g. no opts set by default as config is set in service file
     Old file has no effect since X->Y

 /etc/apparmor.d/libvirt/TEMPLATE 0d5580a22d95fc622cd5b8efe54b8757 obsolete
  => This was even lost prior to the libvirt-daemon-system changes, when things accepted into Debian but split for lxc/qemu
     Old file has no effect since T->X


2. Files gone, that should actually be there (missing in Debian)
For those I think we want to open bugs in Debian and see if they want to pick them (then we stop missing, but instead move them).
Or if there is an agreeable reason to drop intentionally we shall drop them as well completely.
For now in Ubuntu we "keep" them orphaned until that is clear, in case they come back users won't want their old changes thrown away in between.

 /etc/default/virtlockd
  => missing in Debian as well these days, should be available like virtlogd is
     Note: This is referenced from its service file

 /etc/libvirt/libvirt-admin.conf
  => lost together with /etc/libvirt/libvirt.conf (=1 bug)
     Still built and installed in libvirt make, but not getting through to package, analyze and report

** Changed in: libvirt (Ubuntu)
       Status: New => Triaged

** Changed in: libvirt (Ubuntu)
   Importance: Undecided => High

** Changed in: libvirt (Ubuntu)
     Assignee: (unassigned) => ChristianEhrhardt (paelzer)

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to nova in Ubuntu.
https://bugs.launchpad.net/bugs/1694159

Title:
  libvirt-bin dropped conffiles but never cleaned them up on disk

Status in kimchi package in Ubuntu:
  Triaged
Status in libvirt package in Ubuntu:
  Triaged
Status in nova package in Ubuntu:
  Confirmed
Status in ubuntu-virt package in Ubuntu:
  Triaged
Status in uvtool package in Ubuntu:
  Confirmed

Bug description:
  While investigating libvirt/dnsmasq interactions for bug #1694156, I
  noticed that I had redundant files under /etc/dnsmasq.d from libvirt-
  daemon-system and libvirt-bin.  Looking at the status of the libvirt-
  bin package, I see the following:

  Package: libvirt-bin
  Status: install ok installed
  Priority: extra
  Section: oldlibs
  [...]
  Conffiles:
   /etc/default/virtlockd de3684752181bda812f7bf4ef983654c obsolete
   /etc/default/libvirt-bin 619ef67a86531f89f4cf45efde87cb82 obsolete
   /etc/init/libvirt-bin.conf e946cc33fb1161ab19eddccfe526cee5 obsolete
   /etc/dnsmasq.d-available/libvirt-bin bbf7e62e130a4cb7b6db7c4260883a68 obsolete
   /etc/libvirt/libvirt-admin.conf 7c1bbeb439d79ec32ff7d18cb1364e2f obsolete
   /etc/cron.daily/libvirt-bin 21a4c092781e8119b8d5aa9d9d3d9f8b obsolete
   /etc/apparmor.d/libvirt/TEMPLATE 0d5580a22d95fc622cd5b8efe54b8757 obsolete
   /etc/dnsmasq.d/libvirt-bin bbf7e62e130a4cb7b6db7c4260883a68 obsolete

  I see that this is a transitional package, but if the libvirt-bin
  package is going to be built at all from the source, it should be
  taking care to remove the obsolete conffiles on upgrade.  This should
  be done now, even though the actual obsolescence happened some time
  ago.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/kimchi/+bug/1694159/+subscriptions