[Bug 1691428] Fix merged to nova-lxd (stable/ocata)

[OpenStack Infra]

Reviewed:  https://review.openstack.org/465483
Committed: https://git.openstack.org/cgit/openstack/nova-lxd/commit/?id=d7b8e7013be4208c699ecde4224f03bc31d56cf8
Submitter: Jenkins
Branch:    stable/ocata

commit d7b8e7013be4208c699ecde4224f03bc31d56cf8
Author: James Page <james.page at ubuntu.com>
Date:   Wed May 17 10:43:40 2017 +0100

    Pass readonly flag as a string, not a boolean.
    
    The LXD API requires that data be passed as strings; pass the
    readonly flag for config-drive support as a string to ensure
    it can be parsed by LXD avoiding the following error:
    
      json: cannot unmarshal bool into Go value of type string
    
    Change-Id: I0c5dbd9cb8b8ea4f43398849f8b4c33305231d54
    Closes-Bug: 1691428
    (cherry picked from commit 73e33e6ebd1b0ecee76b29835274406ac2a00bd4)

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to Ubuntu Cloud Archive.
https://bugs.launchpad.net/bugs/1691428

Title:
  LXDAPIException: json: cannot unmarshal bool into Go value of type
  string when using config-drive

Status in Ubuntu Cloud Archive:
  New
Status in Ubuntu Cloud Archive newton series:
  New
Status in Ubuntu Cloud Archive ocata series:
  Fix Committed
Status in Ubuntu Cloud Archive pike series:
  New
Status in nova-lxd:
  Fix Released
Status in nova-lxd package in Ubuntu:
  New
Status in nova-lxd source package in Yakkety:
  New
Status in nova-lxd source package in Zesty:
  New
Status in nova-lxd source package in Artful:
  New

Bug description:
  [Impact]
  Not possible to use the config-drive support (as currently in yakkety-proposed, zesty and artful)

  [Test Case]
  Deploy Nova-LXD based OpenStack Cloud
  openstack server create --wait --image xenial --flavor m1.small --key-name testkey --nic net-id=XXXX --min 1 --max 1 --config-drive True xenial-config-drive
  instance will go into ERROR state and fail to boot.

  [Regression Potential]
  Minimal; this feature has never worked correctly, the fix resolves and issue with passing the readonly flag for the config-drive device as a boolean rather than a string (as required by the LXD API).

  [Original Bug Report]
  When booting instances using the --config-drive flag, the instance fail to boot with the following error:

    LXDAPIException: json: cannot unmarshal bool into Go value of type
  string

  nova-lxd is passing the 'readonly' flag as a boolean, not as a string,
  and the LXD API fails to unmarshall it as a result.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1691428/+subscriptions