[Bug 1673411] Re: config-drive support is broken
Andreas Hasenack
andreas at canonical.com
Thu Apr 13 20:01:56 UTC 2017
Verified on yakkety with a yakkety lxd container and the provided
instructions:
*** 0.7.9-90-g61eb03fe-0ubuntu1~16.10.1 500
500 http://archive.ubuntu.com/ubuntu yakkety-proposed/main amd64 Packages
Created a config-drive and verified the result.json file:
$ lxc file pull $name/run/cloud-init/result.json -
{
"v1": {
"datasource": "DataSourceConfigDrive [net,ver=2][source=/config-drive]",
"errors": []
}
}
/config-drive was there:
root at foohost:~# find /config-drive/ -type f
/config-drive/openstack/latest/meta_data.json
/config-drive/openstack/latest/network_data.json
/config-drive/openstack/latest/vendor_data.json
/config-drive/openstack/latest/user_data
/config-drive/openstack/2015-10-15/network_data.json
/config-drive/openstack/2015-10-15/user_data
/config-drive/openstack/2015-10-15/vendor_data.json
/config-drive/openstack/2015-10-15/meta_data.json
To be sure my config-drive was being read, in another attempt I injected a failure into it by setting a link of an unknown type:
$ lxc file pull $name/run/cloud-init/result.json -
{
"v1": {
"datasource": null,
"errors": [
"Unknown network_data link type: dvs-andreas-was-here",
"Unknown network_data link type: dvs-andreas-was-here",
"('ssh-authkey-fingerprints', KeyError('getpwnam(): name not found: ubuntu',))"
]
}
}
As a side note, that prevented the ubuntu user from being created (and
probably other things which do not concern us here).
** Tags added: verification-done-yakkety
--
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to Ubuntu Cloud Archive.
https://bugs.launchpad.net/bugs/1673411
Title:
config-drive support is broken
Status in Ubuntu Cloud Archive:
Triaged
Status in Ubuntu Cloud Archive newton series:
Triaged
Status in Ubuntu Cloud Archive ocata series:
Triaged
Status in cloud-init:
Fix Committed
Status in nova-lxd:
Fix Released
Status in nova-lxd newton series:
Fix Committed
Status in nova-lxd ocata series:
Fix Committed
Status in nova-lxd trunk series:
Fix Released
Status in cloud-init package in Ubuntu:
Fix Released
Status in nova-lxd package in Ubuntu:
Fix Committed
Status in cloud-init source package in Xenial:
Fix Committed
Status in nova-lxd source package in Xenial:
Invalid
Status in cloud-init source package in Yakkety:
Fix Committed
Status in nova-lxd source package in Yakkety:
Triaged
Status in cloud-init source package in Zesty:
Fix Released
Status in nova-lxd source package in Zesty:
Fix Committed
Bug description:
=== Begin cloud-init SRU Template ===
[Impact]
nova-lxd can provide data to instances in 2 ways:
a.) metadata service
b.) config drive
The support for reading the config drive in cloud-init was never
functional. Nova-lxd has changed the way they're presenting the config
drive to the guest. Now they are doing so by populating a directory in
the container /config-drive with the information.
The change added to cloud-init was to extend support read config drive
information from that directory.
[Test Case]
With a nova-lxd that contains the fix this can be fully tested
by launching an instance with updated cloud-init and config drive
attached.
For cloud-init, the easiest way to demonstrate this is to
create a lxc container and populate it with a '/config-drive'.
lxc-proposed-snapshot is
https://git.launchpad.net/~smoser/cloud-init/+git/sru-info/tree/bin/lxc-proposed-snapshot
It publishes an image to lxd with proposed enabled and cloud-init upgraded.
$ release=xenial
$ ref=xenial-proposed
$ name=$release-lp1673411
$ lxc-proposed-snapshot --proposed --publish $release $ref
$ lxc init $ref $name
# lxc will create the 'NoCloud' seed, and the normal search
# path looks there first, so remove it.
$ lxc file pull $name/etc/cloud/cloud.cfg.d/90_dpkg.cfg - |
sed 's/NoCloud, //' |
lxc file push - $name/etc/cloud/cloud.cfg.d/90_dpkg.cfg
## populate a /config-drive with attached 'make-config-drive-dir'
## and push it to the container
$ d=$(mktemp -d)
$ make-config-drive-dir "$d" "$name"
$ rm -Rf "$d"
## start it and look around
$ lxc start $name
$ sleep 10
$ lxc exec $name cat /run/cloud-init/result.json
{
"v1": {
"datasource": "DataSourceConfigDrive [net,ver=2][source=/config-drive]",
"errors": []
}
}
[Regression Potential]
There is a potentiali false positive where a user had data in
/config-drive and now that information is read as config drive data.
That would require a directory tree like:
/config-drive/openstack/2???-??-??/meta_data.json
or
/config-drive/openstack/latest/meta_data.json
Which seems like a small likelyhood of non-contrived hit.
[Other Info]
Upstream commit:
https://git.launchpad.net/cloud-init/commit/?id=443095f4d4b6fe
=== End cloud-init SRU Template ===
After reviewing https://review.openstack.org/#/c/445579/ and doing
some testing, it would appear that the config-drive support in the
nova-lxd driver is not functional.
cloud-init ignores the data presented in /var/lib/cloud/data and reads
from the network accessible metadata-service.
To test this effectively you have to have a fully offline instance
(i.e. no metadata service access).
To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1673411/+subscriptions
More information about the Ubuntu-openstack-bugs
mailing list