[Bug 1503340] Re: actions dir not checked for lint; unused import when checked; unit test fails when lint is resolved.

[Ryan Beisner]

** Also affects: cinder (Juju Charms Collection)
   Importance: Undecided
       Status: New

** Also affects: glance (Juju Charms Collection)
   Importance: Undecided
       Status: New

** Also affects: heat (Juju Charms Collection)
   Importance: Undecided
       Status: New

** Also affects: neutron-api (Juju Charms Collection)
   Importance: Undecided
       Status: New

** Also affects: neutron-gateway (Juju Charms Collection)
   Importance: Undecided
       Status: New

** Also affects: nova-cloud-controller (Juju Charms Collection)
   Importance: Undecided
       Status: New

** Also affects: openstack-dashboard (Juju Charms Collection)
   Importance: Undecided
       Status: New

** Description changed:

- <beisner> coreycb, thedac - i'm on a normalize-makefiles mission for *os-charms.  noticing that some charms aren't lint checking the actions/ dir.  when i enable that, some of them have unused uuid import in actions/openstack_upgrade.py
- <beisner> and when i remove that import, unit tests start to fail with 'actions/openstack_upgrade.py'> does not have the attribute 'uuid'
- <coreycb> beisner, I'd mark that low priority for now
- <thedac> agreed
- <beisner> coreycb, thedac - if i move forward, we'll either have failing lint checks or failing unit checks.
- <beisner> i can just ignore the actions dir for now ?
- <coreycb> beisner, yeah I'd vote for that and a bug
- <thedac> Yes, I would not make the change (yet) that checks the actions directory
- <beisner> fwiw, some do have it lint checks on the actions/ dir enabled, though for the pause/resume actions
- <beisner> be aware ^
- <beisner> so that'll force the next guy to make it right ;-)
- <beisner> on those ones
+ The actions/ dir is not checked for lint by the lint make target.
+ 
+ When lint coverage is added for that dir, there is an unused uuid import
+ error in actions/openstack_upgrade.py.
+ 
+ When that lint issue is resolved, the unit test fails with
+ 'actions/openstack_upgrade.py'> does not have the attribute 'uuid'.
+ 
+ Per #juju irc discussion, I'm temporarily leaving the actions/ dir
+ untested for lint, pending further digging -- except for those charms
+ that are already checking the actions/ dir.  They will continue to check
+ for lint there.

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to cinder in Juju Charms Collection.
Matching subscriptions: charm-bugs
https://bugs.launchpad.net/bugs/1503340

Title:
  actions dir not checked for lint;  unused import when checked;  unit
  test fails when lint is resolved.

Status in ceilometer package in Juju Charms Collection:
  New
Status in ceilometer-agent package in Juju Charms Collection:
  New
Status in cinder package in Juju Charms Collection:
  New
Status in glance package in Juju Charms Collection:
  New
Status in heat package in Juju Charms Collection:
  New
Status in neutron-api package in Juju Charms Collection:
  New
Status in neutron-gateway package in Juju Charms Collection:
  New
Status in nova-cloud-controller package in Juju Charms Collection:
  New
Status in openstack-dashboard package in Juju Charms Collection:
  New

Bug description:
  The actions/ dir is not checked for lint by the lint make target.

  When lint coverage is added for that dir, there is an unused uuid
  import error in actions/openstack_upgrade.py.

  When that lint issue is resolved, the unit test fails with
  'actions/openstack_upgrade.py'> does not have the attribute 'uuid'.

  Per #juju irc discussion, I'm temporarily leaving the actions/ dir
  untested for lint, pending further digging -- except for those charms
  that are already checking the actions/ dir.  They will continue to
  check for lint there.

To manage notifications about this bug go to:
https://bugs.launchpad.net/charms/+source/ceilometer/+bug/1503340/+subscriptions