Bug#562178: icedove: does unnecessary seek without error checking on .signature

[Tim Connors]

Package: icedove
Version: 2.0.0.22-1.1
Severity: normal

If .signature happens to be a named pipe with a program feeding text
into that named pipe, then icedove does *cough* interesting *cough*
things:

[pid 20697] lseek(47, 0, SEEK_CUR)      = -1 ESPIPE (Illegal seek)
[pid 20697] lseek(47, 0, SEEK_CUR)      = -1 ESPIPE (Illegal seek)
[pid 20697] lseek(47, 0, SEEK_CUR)      = -1 ESPIPE (Illegal seek)
[pid 20697] lseek(47, 0, SEEK_CUR)      = -1 ESPIPE (Illegal seek)
[pid 20697] lseek(47, 0, SEEK_CUR)      = -1 ESPIPE (Illegal seek)
[pid 20697] lseek(47, 0, SEEK_CUR)      = -1 ESPIPE (Illegal seek)
[pid 20697] lseek(47, 0, SEEK_CUR)      = -1 ESPIPE (Illegal seek)
[pid 20697] lseek(47, 0, SEEK_CUR)      = -1 ESPIPE (Illegal seek)
[pid 20697] lseek(47, 0, SEEK_CUR)      = -1 ESPIPE (Illegal seek)
[pid 20697] lseek(47, 0, SEEK_CUR)      = -1 ESPIPE (Illegal seek)
[pid 20697] lseek(47, 0, SEEK_CUR)      = -1 ESPIPE (Illegal seek)

Error checking is good, mmmkay?  Reading a .signature file ought not
be any more complicated that while (!eof) { sig+=readline }

Playing around with seek when unnecessary seems just silly (as well as
not very UNIX like).


-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.31-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages icedove depends on:
ii  debianutils            3.2.2             Miscellaneous utilities specific t
ii  fontconfig             2.6.0-4           generic font configuration library
ii  libatk1.0-0            1.28.0-1          The ATK accessibility toolkit
ii  libc6                  2.10.2-2          GNU C Library: Shared libraries
ii  libcairo2              1.8.8-2           The Cairo 2D vector graphics libra
ii  libfontconfig1         2.6.0-4           generic font configuration library
ii  libfreetype6           2.3.11-1          FreeType 2 font engine, shared lib
ii  libgcc1                1:4.4.2-3         GCC support library
ii  libglib2.0-0           2.22.2-2          The GLib library of C routines
ii  libgtk2.0-0            2.18.3-1          The GTK+ graphical user interface 
ii  libhunspell-1.2-0      1.2.8-5           spell checker and morphological an
ii  libjpeg62              6b-15             The Independent JPEG Group's JPEG 
ii  libnspr4-0d            4.8.2-1           NetScape Portable Runtime Library
ii  libnss3-1d             3.12.4-1          Network Security Service libraries
ii  libpango1.0-0          1.26.1-1          Layout and rendering of internatio
ii  libpng12-0             1.2.40-1          PNG library - runtime
ii  libstdc++6             4.4.2-3           The GNU Standard C++ Library v3
ii  libx11-6               2:1.3.2-1         X11 client-side library
ii  libxft2                2.1.13-3          FreeType-based font drawing librar
ii  libxinerama1           2:1.0.3-2         X11 Xinerama extension library
ii  libxrender1            1:0.9.5-1         X Rendering Extension client libra
ii  libxt6                 1:1.0.7-1         X11 toolkit intrinsics library
ii  psmisc                 22.8-1            utilities that use the proc file s
ii  zlib1g                 1:1.2.3.3.dfsg-15 compression library - runtime

icedove recommends no packages.

Versions of packages icedove suggests:
pn  icedove-gnome-support         <none>     (no description available)
ii  latex-xft-fonts               1.6.4-1    TrueType versions of some TeX font
ii  libthai0                      0.1.12-1   Thai language support library

-- no debconf information