[Bug 572074]

Dao+bmo 572074 at bugs.launchpad.net
Sat Apr 16 19:24:25 UTC 2022


Comment on attachment 8781962
middlemouse on new tab button should create a new tab related to current,

> function BrowserOpenNewTabOrWindow(event) {
>-  if (event.shiftKey) {
>+  let where = whereToOpenLink(event);
>+  if (where == "window") {
>     OpenBrowserWindow();
>   } else {
>-    BrowserOpenTab();
>+    // Make new tab related to current except when created via a shortcut <key> command.

This comment doesn't seem accurate, e.g. we don't want to open the tab
related to the current one for plain clicks... right?

>+    let sourceNotKeyEvent = !event.sourceEvent || event.sourceEvent.target.localName != "key";
>+    let relatedToCurrent = (where == "tab" || where == "tabshifted") && sourceNotKeyEvent;
>+    openUILinkIn(BROWSER_NEW_TAB_URL, "tab", {relatedToCurrent,
>+                                              inBackground: where == "tabshifted"});

I'm somewhat confused by this. Why are you not passing through
"tabshifted" as openUILinkIn's 'where' argument?

-- 
You received this bug notification because you are a member of Mozilla
Bugs, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/572074

Title:
  New tabs open to the right of all existing tabs instead of opening
  next to the current tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/572074/+subscriptions




More information about the Ubuntu-mozillateam-bugs mailing list