[Bug 583797]

[Gijskruitbosch+bugs]

(In reply to Meridel from comment #46)
> Prefs copy looks good and hasn't changed from what we have currently.
> 
> Edits to close warning dialogue:
> -Numbers less than ten should be spelled out. So if the user is closing 2 -
> 9 tabs, spell out the number of tabs.

This is really annoying to implement, and requires localizers to provide
translations for all these numbers. It also makes it harder to scan for
the numbers when reading the warning. It's also not clear to me that any
convention in (American?) English that you're using here applies in
other languages (eg I grew up in the Netherlands and the rule I got
taught was to write out numbers under 20, as well as any numbers
divisible by 10 (under 100) or 100 (under 1000), etc.). So it would be
"five thousand tabs" but "5341 tabs". I would be unsurprised if other
languages used other conventions still. It also doesn't seem related to
this bug. If you feel strongly that this is necessary, can you file a
separate bug for this, maybe with more details about how that should
work?

For the changes to the prefs:

(In reply to Amy Lee [:amylee] UX from comment #44)
> I've attached a spec for Preferences when Session Restore is Enabled and
> Disabled. The warning will not show up by default if Session Restore is
> enabled but I've added a pref that allows users to turn the warning message
> on when Session Restore is enabled if desired. 

I have a several concerns here.

First, now if users have session restore enabled there is 1 pref that
governs both window closing and quitting. Unfortunately, there isn't a
pref to turn on warnings for quit but not have warnings when closing
multiple tabs otherwise. This would be desirable because it's easy to
mis-hit cmd-q when trying to hit cmd-w (to close a tab). You have to try
pretty hard to mis-hit cmd-shift-w (to close a window) or to close
multiple tabs using the mouse. So I want a warning when quitting but not
when closing a window, but I can't have that either today or with the
implementation you're suggesting. That seems like something we should
fix.

Second, users who are used to the current behavior with session restore
enabled (esp. on Windows, where mis-hitting ctrl-shift-q is also not a
major concern) will start getting warning dialogs when we implement the
new behavior. That seems disruptive. But we can't turn off the warning
everywhere because then they won't get a warning when closing a window,
which they might have relied upon. Any thoughts about how to address
that?

-- 
You received this bug notification because you are a member of Mozilla
Bugs, which is subscribed to Mozilla Firefox.
https://bugs.launchpad.net/bugs/583797

Title:
  "Warn on closing with multiple tabs open" not honored

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/583797/+subscriptions