[Bug 220263]

[L. David Baron]

I suspect that many aspects of this actually were fixed at various
times.  But the hard part is to prevent all the CSS changes in the
browser front-end from triggering some aspect of it again.  (At one
point I think I'd made a testing mode in which the correct
foreground/background pairs were always the same color, so that no text
should be visible, that could be used to check that colors were matched
correctly.  I'm not sure if I even landed the code for it or what
happened to it since.)  I'd also done some work to document what those
pairs were, i.e., the rules for which native-theme-derived foreground
color should be matched with which background color so that themes work
correctly.  (-moz-appearance makes this a bit more complicated, since
foreground colors could be matched with a -moz-appearance background as
well.)

The number of comments recently makes me suspect that something got
*worse* recently.

In theory fixing this probably requires:
 * documenting what the valid foreground-color and (background-color or -moz-appearance) pairs are for use of colors from native themes
 * developing a mechanism to check that the UI uses only those pairs together and nothing else (probably by making each pair render the same (bright) color as a diagnostic
 * auditing the Firefox UI
 * checking that the things we're extracting from GTK themes make sense with the rules that we're applying

-- 
You received this bug notification because you are a member of Mozilla
Bugs, which is subscribed to XULRunner.
https://bugs.launchpad.net/bugs/220263

Title:
  Bad Firefox integration with dark themes

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/220263/+subscriptions