[Bug 583797]

[Gijskruitbosch+bugs]

Comment on attachment 9004028
0000-fixquit.patch make warn=true warn again

Thanks for the suggested patch.

There's a plan and UX design in bug 550559, and that'll involve more
work than just changing this check. I'd take an updated patch in that
bug (I'll dupe this over in a sec). It looks like you'd need to also
update the label in the preferences ( https://searchfox.org/mozilla-
central/rev/c3fef66a5b211ea8038c1c132706d02db408093a/browser/components/preferences
/in-content/main.xul#88-89 - change the identifier for l10n there, and
change the identifier and string in https://searchfox.org/mozilla-
central/rev/c3fef66a5b211ea8038c1c132706d02db408093a/browser/locales/en-
US/browser/preferences/preferences.ftl#179-181 ), and there may be some
automated tests that need adjusting.

I'm also not sure what branch you wrote this patch against - but it
wouldn't apply against nightly, because the code has changed and also
checks the warnOnClose pref now (which it should probably keep doing, at
least for now).

Finally, for your next patch, please could you post something generated
by `hg export` or `git show` instead of just the diff, so that the
commit properly credits you and includes a summary of the change (ie
commit message). Thank you!

-- 
You received this bug notification because you are a member of Mozilla
Bugs, which is subscribed to Mozilla Firefox.
https://bugs.launchpad.net/bugs/583797

Title:
  "Warn on closing with multiple tabs open" not honored

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/583797/+subscriptions