[Bug 1562385] Re: Crash Annotation GraphicsCriticalError: |[0][GFX1]: Unknown image format 0[GFX1]: Unknown image format 0 Crash Annotation GraphicsCriticalError: |[0][GFX1]: Unknown image format 0|[1][GFX1]: Unknown image format 0[GFX1]: Unknown image format 0

[Lionelh]

After struggling with this for several months I've found what I believe
is the source of this bug.  I had to go back and look at Firefox 44.0,
the last version to build without exhibiting the flashing.  I discovered
that a change between versions 44.0 and 45.0, Bug 1209812 - Add endian-
neutral variants to SurfaceFormat, was the culprit.

I believe error is in the below code changes to gfx/2d/Types.h:

  // The following values are endian-independent synonyms. The _UINT32 suffix
  // indicates that the name reflects the layout when viewed as a uint32_t
  // value.
#if MOZ_LITTLE_ENDIAN
  A8R8G8B8_UINT32 = B8G8R8A8,       // 0xAARRGGBB
  X8R8G8B8_UINT32 = B8G8R8X8        // 0x00RRGGBB
#elif MOZ_BIG_ENDIAN
  A8R8G8B8_UINT32 = A8R8G8B8,       // 0xAARRGGBB
  X8R8G8B8_UINT32 = X8R8G8B8        // 0x00RRGGBB
#else
# error "bad endianness"
#endif

As I understand from reading the endianness values that preceed this
code, the endian test should be reserved to be:

#if MOZ_BIG_ENDIAN
  A8R8G8B8_UINT32 = B8G8R8A8,       // 0xAARRGGBB
  X8R8G8B8_UINT32 = B8G8R8X8        // 0x00RRGGBB
#elif MOZ_LITTLE_ENDIAN
  A8R8G8B8_UINT32 = A8R8G8B8,       // 0xAARRGGBB
  X8R8G8B8_UINT32 = X8R8G8B8        // 0x00RRGGBB
#else
# error "bad endianness"
#endif

I've used this to patch Firefox which allows me to successfully build
both Firefox 46 and 47 that do not exhibit the graphics flashing.

** Attachment added: "patch-gfx-2d-Types.h"
   https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1562385/+attachment/4739563/+files/patch-gfx-2d-Types.h

-- 
You received this bug notification because you are a member of Mozilla
Bugs, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1562385

Title:
  Crash Annotation GraphicsCriticalError: |[0][GFX1]: Unknown image
  format 0[GFX1]: Unknown image format 0 Crash Annotation
  GraphicsCriticalError: |[0][GFX1]: Unknown image format 0|[1][GFX1]:
  Unknown image format 0[GFX1]: Unknown image format 0

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1562385/+subscriptions