[Bug 263661]

Karlt 263661 at bugs.launchpad.net
Fri Feb 21 23:02:03 UTC 2014


Comment on attachment 497112
Use EXTEND_PAD on X

>-                if (fastExtendPad) {
>-                    aPattern->SetExtend(gfxPattern::EXTEND_PAD);
>-                    aPattern->SetFilter(aDefaultFilter);
>-                } else
>-#endif
>-                    aPattern->SetFilter(gfxPattern::FILTER_FAST);
>+
>+            if (!isDownscale && !fastExtendPad) {
>+                aPattern->SetFilter(gfxPattern::FILTER_FAST);
>             }
>+

Looks like an else block with SetFilter(aDefaultFilter) is needed.
Without this patch, that currently only happens when !isDownscale, but I expect it should also be done when !isDownscale, as on other platforms.

Otherwise, this approach of using EXTEND_PAD when supported by cairo
seems sensible to me.

-- 
You received this bug notification because you are a member of Mozilla
Bugs, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/263661

Title:
  Black Line appears next to gif and png images

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/263661/+subscriptions




More information about the Ubuntu-mozillateam-bugs mailing list