[Bug 217300]

[Jhorak]

(In reply to neil at parkwaycc.co.uk from comment #78)
> Comment on attachment 706354
> Store Master Password to Gnome Keyring patch v1
> 
> You need build system and PSM reviews, so I'll just comment on code patterns.
> 
> >+      PRUnichar *password = nullptr;
> >+      nsAutoString promptString;
> >+      
> >+      // Get prompt message for Gnome Keyring master password
> >+      nsCOMPtr<nsINSSComponent> nssComponent(do_GetService(kNSSComponentCID, &rv));
> >+      if (NS_FAILED(rv))
> >+        return;
> >+
> >+      const PRUnichar* formatStrings[1] = { 
> >+        ToNewUnicode(NS_LITERAL_STRING("Gnome Keyring"))
> >+      };
> NS_NAMED_LITERAL_STRING gnomeKeyring("Gnome Keyring");
> const PRUnichar* formatStrings[] = { gnomeKeyring.get() };
> Or since this is linux-only, MOZ_LL, NS_LL or u"Gnome Keyring" might work.
> This avoids having to free the string manually.

Thanks for feedback.
The u"str" or NS_LL is char16_t*. I'm not sure if I can safely cast it to PRUnichar), can I?

-- 
You received this bug notification because you are a member of Mozilla
Bugs, which is subscribed to Mozilla Firefox.
https://bugs.launchpad.net/bugs/217300

Title:
  Seahorse integration

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/217300/+subscriptions