[Bug 991033]

Dbienvenu 991033 at bugs.launchpad.net
Thu May 17 15:06:21 UTC 2012


Comment on attachment 617270
Fix offline handling in _uploaderCallback

sorry for the delay in getting to this:

these don't seem to be used:

+  _authToken: "",
+  _lastErrorStatus : 0,
+  _lastErrorText : "",

I tried uploading a 43MB file - it never seemed to finish, even after
waiting several minutes. A 300K message finished in a few seconds. A 9MB
attachment failed after about 3 minutes. This might be something with my
network, but it worked with other providers in about 20 seconds.

The code looks good, in general. I tried changing my password on the
UbuntuOne site, removed my auth token from the password manager, and my
next attempt to upload caused a password prompt in TB, so that's good.
Changing my password maybe should invalidate my auth token, but that's
something to worry about on the server side...

I'll run through the mozmill tests in a minute.

You'll want a ui review from Blake. The one thing I noticed is that
during account setup, once I enter an e-mail address, the "get new
account link" mostly disappears, but not quite, so it looks a bit off.

I notice you have new strings in management.dtd and settings.dtd. We're
way past string freeze for TB 14, so we'll need to think about what to
do there.

-- 
You received this bug notification because you are a member of Mozilla
Bugs, which is subscribed to Mozilla.
https://bugs.launchpad.net/bugs/991033

Title:
  Add UbuntuOne support for Filelink in Thunderbird 13

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/991033/+subscriptions




More information about the Ubuntu-mozillateam-bugs mailing list