[Bug 367531]

[Adam Dane]

Created attachment 656680
Fix broken tests, move ensureSocketThreadTargetIfOnline to ensureSocketThreadTarget

The |test_error_codes.js| test failure was getting
|NS_ERROR_NOT_INITIALIZED| from |nsHTTPConnectionMgr::PostEvent|;
|EnsureSocketThreadTargetIfOnline| becomes |EnsureSocketThreadTarget|
and the test gets updated.

The other tests broke because localhost is now reachable in offline
mode.  The fix for all three is disabling the proxy
("network.proxy.type" to |0|) when those tests are offline.  They would
pass when run in isolation, either because the proxy itself hadn't been
resolved before or maybe there's some browser-side caching of proxy
endpoints?

The potential deadlock situation appears to be the cause for at least
one crash [1].  That crash is related to the test for bug 336682, which
is offline-mode related, though the test itself passed.  This patch will
call |Reset| outside of the locked block.

1. https://tbpl.mozilla.org/php/getParsedLog.php?id=14768084&tree=Try

Pushed to try:
https://tbpl.mozilla.org/?tree=Try&rev=a1a4ebe12100

-- 
You received this bug notification because you are a member of Mozilla
Bugs, which is subscribed to Mozilla Firefox.
https://bugs.launchpad.net/bugs/367531

Title:
  firefox should be smarter about offline access

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/367531/+subscriptions