[Bug 991033] Re: Add UbuntuOne support for Filelink in Thunderbird 13

[Bug Watch Updater]

Launchpad has imported 5 comments from the remote bug at
https://bugzilla.mozilla.org/show_bug.cgi?id=744037.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2012-04-10T16:23:41+00:00 Mike Conley wrote:

We're aiming to support UbuntuOne with the Filelink feature.

Reply at: https://bugs.launchpad.net/thunderbird/+bug/991033/comments/0

------------------------------------------------------------------------
On 2012-04-19T15:35:52+00:00 Dbienvenu wrote:

Created attachment 616588
initial patch from Ubuntu

Reply at: https://bugs.launchpad.net/thunderbird/+bug/991033/comments/1

------------------------------------------------------------------------
On 2012-04-20T22:27:20+00:00 Dbienvenu wrote:

Created attachment 617120
fix a few issues

This fixes a bit rot issue with the previous patch, and makes uploading
files that we don't know the mime type of work (it was failing because
the code wasn't catching the exception, so I've fixed that). I've also
fixed the offline error to use throw.

With those changes, I was able to sign up for a UbuntuOne account and
send a filelink, so the basics seem to work.

Reply at: https://bugs.launchpad.net/thunderbird/+bug/991033/comments/2

------------------------------------------------------------------------
On 2012-04-21T14:57:51+00:00 James Henstridge wrote:

Created attachment 617224
The latest version of my work

Here is my latest work on the Ubuntu One backend, squashed down to a
single changeset and rebased on tip.  I'm just rebuilding to test the
backend, so if I discover any issues I'll post an updated patch.

I hope I've incorporated the offlineErr changes from David's update
correctly.

This version also includes mozmill tests, giving a similar level of
coverage as the other backends.

One thing missing from the patch at the moment is the referral codes in
the links.  Once we've sorted out what they should be, I'll post an
update.

Reply at: https://bugs.launchpad.net/thunderbird/+bug/991033/comments/3

------------------------------------------------------------------------
On 2012-04-22T02:02:29+00:00 James Henstridge wrote:

Created attachment 617270
Fix offline handling in _uploaderCallback

I noticed that the try/catch hadn't been added to _uploaderCallback() as
part of the offline error handling, so I've added that.  This seems to
have all of David's changes, so this is the patch to review.

As with the last patch, it still needs the referral codes in some of the
links, but that shouldn't prevent the code itself from being reviewed.

Reply at: https://bugs.launchpad.net/thunderbird/+bug/991033/comments/4


** Changed in: thunderbird
       Status: Unknown => In Progress

** Changed in: thunderbird
   Importance: Unknown => Medium

-- 
You received this bug notification because you are a member of Mozilla
Bugs, which is subscribed to Mozilla.
https://bugs.launchpad.net/bugs/991033

Title:
  Add UbuntuOne support for Filelink in Thunderbird 13

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/991033/+subscriptions