[Bug 684376]

Timothy Arceri 684376 at bugs.launchpad.net
Tue Sep 20 22:58:28 UTC 2011


Hi Robert,
          Thanks for taking a look at the patch so quickly. To answer your question, no nothing else needs to be changed.

The code that sets pdf to default is in nsPrintSettingsGTK.cpp this
checks the extension of the string that I have changed:

  if (StringEndsWith(nsDependentString(aToFileName), NS_LITERAL_STRING(".ps"))) {
    gtk_print_settings_set(mPrintSettings, GTK_PRINT_SETTINGS_OUTPUT_FILE_FORMAT, "ps");
  } else {
    gtk_print_settings_set(mPrintSettings, GTK_PRINT_SETTINGS_OUTPUT_FILE_FORMAT, "pdf");
  }

Maybe it could be improved so that the string is set to mozilla. rather
than mozilla.pdf then the extension is attached in
nsPrintSettingsGTK.cpp after the print setting is set.

Note: The whole setting of the extension in the application seems a bit
messy and I've suggested an improvement to GTK here
https://bugzilla.gnome.org/show_bug.cgi?id=657322

-- 
You received this bug notification because you are a member of Mozilla
Bugs, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/684376

Title:
  Change 'Print to File' default to PDF

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/684376/+subscriptions




More information about the Ubuntu-mozillateam-bugs mailing list