[Bug 222635]

[Michal-novotny]

Comment on attachment 571265
Part 2. "301: <encoding>" works on nsIndexedToHTML correctly v2

> +nsresult
> +nsIndexedToHTML::OnHeaderAvailable(nsIRequest* request, nsISupports *aContext,
> +                                   nsString& aBuffer)

I think the name of the method is confusing. A name like WriteHeader
would be IMO more appropriate. You could also move the check of
mWroteHeader inside the method.


> +    bool mWroteHeader;

This member isn't initialized in the constructor.


> +    bool failbackCharset = encoding.Equals("ISO-8859-1");

s/failback/fallback/ ?


>      if (mExpectAbsLoc &&
> -        NS_SUCCEEDED(net_ExtractURLScheme(utf8UnEscapeSpec, nsnull, nsnull, nsnull))) {
> +        NS_SUCCEEDED(net_ExtractURLScheme(convertedUnEscapeSpec, nsnull, nsnull, nsnull))) {
>          // escape as absolute.
> -        escFlags = esc_Forced | esc_OnlyASCII | esc_AlwaysCopy | esc_Minimal;
> +        escFlags |= esc_Forced | esc_AlwaysCopy | esc_Minimal;
>      }

As far as I can see, this can be removed completely. mExpectAbsLoc was
set to true only in case of gopher and support for this protocol was
removed.

-- 
You received this bug notification because you are a member of Mozilla
Bugs, which is subscribed to Mozilla.
https://bugs.launchpad.net/bugs/222635

Title:
  firefox ftp client don't understand links in cyrillic letters

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/222635/+subscriptions