612377 at bugs.launchpad.net
Tue Mar 29 04:43:26 UTC 2011
(In reply to comment #166)
> >+#define PAD(size, align) (((size) + (align) - 1) & (~((align) - 1)))
> I usually prefer functions over macros for the additional type safety and to
> avoid evaluating arguments twice (e.g. PAD(x, a++))
My experience has been that the compiler does a good job of optimizing
out that duplication of effort, and the lack of overhead of the
additional function call usually makes up for it, but in the specific
case we're referring to, it doesn't matter enough to worry about, and
using a function call is more consistent with the way it worked before.
Re-submitted as attachment 522583.
You received this bug notification because you are a member of Mozilla
Bugs, which is subscribed to Mozilla.
More information about the Ubuntu-mozillateam-bugs