[Bug 740815] Re: [FFe] Updates to enable us to drop xulrunner from main

Bug Watch Updater 740815 at bugs.launchpad.net
Wed Mar 23 15:04:50 UTC 2011


Launchpad has imported 19 comments from the remote bug at
https://bugzilla.mozilla.org/show_bug.cgi?id=628723.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2011-01-25T18:38:03+00:00 Wes Garland wrote:

I would like to release a JS 1.8.5 tar ball ~ concurrently with Firefox
4.

Here is a sample tar-ball and browseable tree based on a snapshot of
today's tracemonkey repo: http://www.page.ca/~wes/js-releng/

Some notes where I've differed from the existing release process at
http://www.mozilla.org/js/spidermonkey/release-notes/spidermonkey-
releases.html:

 - run autoconf213 in js/src so that we ship a working "configure"
 - steps related to Makefile.ref, js.mak, etc elided
 - I have not updated the change log. Is this really necessary? Is there a non-manual way to do this?  There were ... several ... changes made between 1.7.0 and 1.8.5
 - Obviously, CVS tagging no longer applies. How about we tag the hg rev we push with bug 586016?
 - Tar now has one more top-level directory -- this is to allow us to ship things like NSPR and jemalloc later if we want to in the same tar ball
 - README moved to higher level dir

Also.... Can I please, please change "libmozjs.so" to a better name in
the tar release? How about libmozjs185.so.1.0.0?  I think this would
help the distro use-case, and make it possible to ship bug fixes on top
of JS-1.8.5-the-language -- while properly advertising API/ABI
compatibility. And, of course, making room for JS-1.8.6-the-language.

Reply at: https://bugs.launchpad.net/firefox/+bug/740815/comments/0

------------------------------------------------------------------------
On 2011-01-26T01:26:19+00:00 Pbiggar wrote:

(In reply to comment #0)
> Also.... Can I please, please change "libmozjs.so" to a better name in the tar
> release? How about libmozjs185.so.1.0.0?  I think this would help the distro
> use-case, and make it possible to ship bug fixes on top of
> JS-1.8.5-the-language -- while properly advertising API/ABI compatibility. And,
> of course, making room for JS-1.8.6-the-language.

Bug 618631 does this, sort of. It hasn't had any action lately, so you
may have to pick up the pieces.

With regard to the actual number, what version was the last beta we put
out? Should we not be changing major numbers (is that the 1 or the 8?)
since we've broken everything since our last release? I think we
previously were somehow tied to Gecko version numbers (?); are you
proposing breaking away from this?

Reply at: https://bugs.launchpad.net/firefox/+bug/740815/comments/1

------------------------------------------------------------------------
On 2011-01-31T18:17:00+00:00 Pbiggar wrote:

(In reply to comment #1)
> Bug 618631 does this, sort of. It hasn't had any action lately, so you may have
> to pick up the pieces.

I meant 618381, my apologies.

Reply at: https://bugs.launchpad.net/firefox/+bug/740815/comments/2

------------------------------------------------------------------------
On 2011-03-01T19:10:59+00:00 Matt-adams wrote:

I suppose I should chime in here and say that a new official release is
really important for those of us who are working with CouchDB on
Android.  Newer versions of libmozjs are absolutely essential for
Android and there is (not unwarranted) hesitation amongst the CouchDB
folks to use an unofficial release of Spidermonkey.

In short, a new release is something that I would REALLY like to see.

Reply at: https://bugs.launchpad.net/firefox/+bug/740815/comments/3

------------------------------------------------------------------------
On 2011-03-01T21:14:50+00:00 Wes Garland wrote:

For what it's worth -- Chris Coulson (copied on this bug already) from
Ubuntu is maintaining a CouchDB fork which compiles on tracemonkey tip.

Hopefully a JS 185 source release will be adopted quickly by Ubuntu and
spur Couch into taking Chris' patches.

Once Firefox 4 ships, I'll take a stab another release candidate and
hopefully Boss at Moz will bless it.

Reply at: https://bugs.launchpad.net/firefox/+bug/740815/comments/4

------------------------------------------------------------------------
On 2011-03-02T01:38:13+00:00 Jorendorff wrote:

A few points:

- I think this is a great idea and I'm thrilled that Wes is taking the
job.

- Let's call it 1.8.5 and libmozjs185. SpiderMonkey version numbers have
  historically tracked the language version, not the Gecko version.

- We will not take any patches (in the tracemonkey repo or mozilla-central)
  before Firefox 4 ships for this purpose.

- We will not take any patches in the stable Firefox 4 release branch
  for this purpose either.

- Wes's plan, as I understand it, is to wait for Firefox 4 to ship, take
  that revision (the one we ship), make minimal changes to it (which will not
  land upstream, at least not instantly), *maybe* throw in NSPR or something,
  and tar it up. Sounds good to me.

>  - run autoconf213 in js/src so that we ship a working "configure"
>  - steps related to Makefile.ref, js.mak, etc elided
>  - I have not updated the change log. Is this really necessary? Is there a
> non-manual way to do this?  There were ... several ... changes made between
> 1.7.0 and 1.8.5

Skip the changelog. Point to http://hg.mozilla.org/tracemonkey if you
think anybody cares.

>  - Obviously, CVS tagging no longer applies. How about we tag the hg rev we
> push with bug 586016?

If you intend to base the source release off Firefox 4 final, that will
already have a tag. There's no point tagging it more. The source
release's README that explains what revision it's based on and what
changes you made.

>  - Tar now has one more top-level directory -- this is to allow us to ship
> things like NSPR and jemalloc later if we want to in the same tar ball
>  - README moved to higher level dir

Great.

> Also.... Can I please, please change "libmozjs.so" to a better name in the tar
> release? How about libmozjs185.so.1.0.0?  I think this would help the distro
> use-case, and make it possible to ship bug fixes on top of
> JS-1.8.5-the-language -- while properly advertising API/ABI compatibility. And,
> of course, making room for JS-1.8.6-the-language.

Wes clarified on IRC that he means a one-line change. The Makefile.in in
the source distribution would have a different LIBRARY_NAME= than trunk.
I think this is a good idea. It is definitely better than stopping right
now to figure out an ideal versioning story.

Delivering something called "libmozjs185" makes it easy for us to adopt
a completely different and superior versioning scheme later with no risk
of breaking people who adopt this release.

Reply at: https://bugs.launchpad.net/firefox/+bug/740815/comments/5

------------------------------------------------------------------------
On 2011-03-02T03:24:28+00:00 Pbiggar wrote:

(In reply to comment #5)
> - I think this is a great idea and I'm thrilled that Wes is taking the job.

Agreed, great job Wes.


> >  - Tar now has one more top-level directory -- this is to allow us to ship
> > things like NSPR and jemalloc later if we want to in the same tar ball
> >  - README moved to higher level dir

This is pretty non-standard for unix source packages, is it possible to
put NSPR/jemalloc into the JS directory?

Reply at: https://bugs.launchpad.net/firefox/+bug/740815/comments/6

------------------------------------------------------------------------
On 2011-03-02T03:36:34+00:00 Wes Garland wrote:

I think we want to stick with the directory structure current present in
the hg repo.

Altering it for source releases means further modifications to the build
system, and potential future-compatibilty gotchas; I think we really
want to keep the source release story as simple as possible, and to make
it as easy as possible for source-release users to become hg-clone
users.

If you want to get technical about what's normal for a unix source
package - NSPR and jemalloc would normally be completely separate
packages, and at least NSPR probably will be distributed separately by
Ubuntu et al.  Jemalloc is less likely to be distributed separately, as
it is radically different from upstream and has only one customer. Well,
maybe two if XULRunner uses it.

Including NSPR with the shell is primarily to ease building -
particularly for win32 - when JS_THREADSAFE goes away.

Reply at: https://bugs.launchpad.net/firefox/+bug/740815/comments/7

------------------------------------------------------------------------
On 2011-03-02T20:48:09+00:00 Paul J. Davis wrote:

I'd just like to add that the CouchDB team would be extremely
appreciative of a new source release. Once its released we'll move
pretty quickly to pull in the downstream changes from Ubuntu and drop
support for the 1.7 release.

I'd also like to specifically voice support for shipping the working
configure script with the source release as that'd prevent us from
requiring two versions of autoconf when building from a vcs checkout.

Reply at: https://bugs.launchpad.net/firefox/+bug/740815/comments/8

------------------------------------------------------------------------
On 2011-03-06T14:01:33+00:00 Wes Garland wrote:

Jason, what do you think about taking bug 630209 (Igor's changes to
JS_Compile*Script et al) for the the JS 1.8.5 source release?

It seems to be embedder-friendly, ready, and already landed in
tracemonkey.

Reply at: https://bugs.launchpad.net/firefox/+bug/740815/comments/9

------------------------------------------------------------------------
On 2011-03-07T04:26:17+00:00 Wes Garland wrote:

I have created an hg repo at https://bitbucket.org/wesgarland/js-1.8.5/
to track my work on this bug.

The repository currently contains SpiderMonkey based on Mozilla-2.0 rev
5f8f494a4c29 (FIREFOX_4_0rc1_BUILD1), minor standalone-oriented tweaks
to Makefile.in, corresponding changes to the README, and the patch for
bug 630209 discussed above.

I don't have a Windows platform on which to do a test build. Any
volunteers?

http://www.page.ca/~wes/js-releng/js-1.8.5-rc1/js-1.8.5.tar.gz

As an embedder, this is pretty much what I'd want to see in a JS 1.8.5
source release. What do you think?

Reply at: https://bugs.launchpad.net/firefox/+bug/740815/comments/10

------------------------------------------------------------------------
On 2011-03-07T16:40:30+00:00 Evilpies wrote:

Works for me,
both "make" and "make install". Got a working shell in dist/bin, and the dll.

Reply at: https://bugs.launchpad.net/firefox/+bug/740815/comments/11

------------------------------------------------------------------------
On 2011-03-07T17:34:43+00:00 Wes Garland wrote:

Thanks, Tom.

This means we have passed "yes, it compiles" tests on Windows,
Leopard/x86, Debian Linux/x86 and Solaris 10/sparc.

Reply at: https://bugs.launchpad.net/firefox/+bug/740815/comments/12

------------------------------------------------------------------------
On 2011-03-07T20:02:04+00:00 Pbiggar wrote:


> This means we have passed "yes, it compiles" tests on Windows, Leopard/x86,
> Debian Linux/x86 and Solaris 10/sparc.

I suggest pushing to TryServer. That would build a shell with lots of
options on those platforms.

Reply at: https://bugs.launchpad.net/firefox/+bug/740815/comments/13

------------------------------------------------------------------------
On 2011-03-08T01:36:35+00:00 Wes Garland wrote:

 - try server does not do shell-only builds AFAIK
 - try server expects repositories related (in the DAG sense) to mozilla-central

(Unless you know something I don't)

Wes

Reply at: https://bugs.launchpad.net/firefox/+bug/740815/comments/14

------------------------------------------------------------------------
On 2011-03-22T20:34:42+00:00 Wes Garland wrote:

I've begun writing release notes at
https://developer.mozilla.org/en/SpiderMonkey/1.8.5

Reply at: https://bugs.launchpad.net/firefox/+bug/740815/comments/15

------------------------------------------------------------------------
On 2011-03-23T09:48:37+00:00 Chris Coulson wrote:

Excellent, thanks. I'm going to push this to Ubuntu ASAP

Reply at: https://bugs.launchpad.net/firefox/+bug/740815/comments/24

------------------------------------------------------------------------
On 2011-03-23T13:09:39+00:00 Wes Garland wrote:

Chris -- if you take my release candidate before the official moz-stamp,
please be aware that

1. The current tar ball has a spelling error in the README which has
been fixed in the hg repo on bitbucket

2. There exists the possibility that this will not in fact be the
official release, potentially confusing your users when moz releases
something different

Reply at: https://bugs.launchpad.net/firefox/+bug/740815/comments/37

------------------------------------------------------------------------
On 2011-03-23T13:11:44+00:00 Chris Coulson wrote:

Thanks. I'll mark our build as a release candidate for now

Reply at: https://bugs.launchpad.net/firefox/+bug/740815/comments/38


** Changed in: firefox
       Status: Unknown => In Progress

** Changed in: firefox
   Importance: Unknown => Medium

-- 
You received this bug notification because you are a member of Mozilla
Bugs, which is subscribed to Mozilla.
https://bugs.launchpad.net/bugs/740815

Title:
  [FFe] Updates to enable us to drop xulrunner from main




More information about the Ubuntu-mozillateam-bugs mailing list