[Bug 412647]

[Stefan Kost]

(In reply to comment #227)
> Comment on attachment 503489 [details]
> Latest Gstreamer patch
> 
> +static GstFlowReturn gst_fennecvideosink_buffer_alloc(GstBaseSink* aBsink,
> +{
> +  // Allocate a buffer with new
> +  void *newBuffer;
> 
> +  // Allocating 128 byte aligned memory.
> +  if (posix_memalign(&newBuffer, 128, ROUND_UP(aSize, 128)) != 0)
> +    newBuffer = NULL;
> 
> +  if (!*aBuf) {
> +    // Release the mem we got
> +    delete [] newBuffer;
> 
> coverity notes that delete (array) is wrong for void*. your allocator here is
> posix memalign, so the release should be posix-something not c++ delete

For performance reasons it would be really good if the sink could manage
a list of buffers and receycle them. Ideally the memory would point to a
location where fennec would render from so that no extra dcopy or other
data transfer would be needed.

-- 
You received this bug notification because you are a member of Mozilla
Bugs, which is subscribed to Mozilla Firefox.
https://bugs.launchpad.net/bugs/412647

Title:
  Firefox is not able to play mp4 <video> tags