[Bug 539226]

[Karlt]

Comment on attachment 501632
Patch 0.8, fixed comments and added mount operation enum

>+nsGIOInputStream::SetMountResult(GMountOperationResult result, gint error_code)
>+{
>+  mozilla::MonitorAutoEnter mon(mMonitorMountInProgress);
>+  mMountRes = (result == G_MOUNT_OPERATION_HANDLED) 
>+      ? MOUNT_OPERATION_SUCCESS : MOUNT_OPERATION_FAILED;

SetMountResult is only used in this file and the parameter is not really a
GMountOperationResult.  It should be the internal enum "MountOperationResult".

>+      , mMountRes(MOUNT_OPERATION_IN_PROGRESS)

mMountRes is only used in nsGIOInputStream::MountVolume() so doesn't need to
be initialized here.

>+  /* A g_file_mount_enclosing_volume is using dbus request to mount
volume.

"/* g_file_mount_enclosing_volume uses a dbus request to mount the
volume."

>+     Callback mount_enclosing_volume_finished is called in main thread 
>+     (not this thread from witch it this method called). */

"(not this thread on which this method is called)."

-- 
You received this bug notification because you are a member of Mozilla
Bugs, which is subscribed to firefox in ubuntu.
https://bugs.launchpad.net/bugs/539226

Title:
  firefox(-gnome-support) should be compiled with Gio support instead GnomeVFS