[Bug 303269]

Mon Aug 8 21:05:57 UTC 2011

Comment on attachment 551030
patch v2.5

>diff -r 61bb2bb510c9 editor/libeditor/html/tests/test_bug484181.html
> function runTest() {
>   gMisspeltWords = ["haz", "cheezburger"];
>+  var edit = document.getElementById("edit");
>+  edit.focus();
>+  SimpleTest.executeSoon(function() {
>   is(isSpellingCheckOk(), true, "All misspellings before editing are accounted for.");
> 
>-  var edit = document.getElementById("edit");
>   append(" becaz I'm a lolcat!");
>   SimpleTest.executeSoon(function() {
>   gMisspeltWords.push("becaz");
>   gMisspeltWords.push("lolcat");
>   is(isSpellingCheckOk(), true, "All misspellings after typing are accounted for.");
> 
>   SimpleTest.finish();
>   });
>+  });
> }

Nit: could you please adjust the indentation here?

>diff -r 61bb2bb510c9 extensions/spellcheck/src/mozInlineSpellChecker.cpp
>+    if (NS_FAILED(rv))
>+      continue;

Why is this change needed?

>diff -r 61bb2bb510c9 layout/reftests/editor/338427-2.html
>--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
>+++ b/layout/reftests/editor/338427-2.html	Thu Aug 04 23:34:57 2011 +0200
>@@ -0,0 +1,16 @@
>+<!DOCTYPE html>
>+<html class="reftest-wait">
>+<script>
>+function init() {
>+    var editor = document.getElementById('editor');
>+    editor.addEventListener("focus", function() {
>+        editor.blur();
>+        document.documentElement.className = '';
>+    }, false);
>+    editor.focus();

As I said before, this is wrong.

Also, it's probably a good idea for you to run the reftests manually to
verify that these tests path.  You can do this with this command, for
example:

make -C /path/to/objdir reftest
TEST_PATH=layout/reftests/editor/reftest.list

>diff -r 61bb2bb510c9 toolkit/content/InlineSpellChecker.jsm
>-    if (! spellchecker.CheckCurrentWord(this.mMisspelling))
>-      return 0;  // word seems not misspelled after all (?)
>+    try {
>+      if (! spellchecker.CheckCurrentWord(this.mMisspelling))
>+        return 0;  // word seems not misspelled after all (?)
>+    } catch(e) {
>+        return 0;
>+    }

Why is this change needed?

>-    var curlang = spellchecker.GetCurrentDictionary();
>+    var curlang = "";
>+    try {
>+        curlang = spellchecker.GetCurrentDictionary();
>+    } catch(e) {}

Also, why is this one needed?

-- 
You received this bug notification because you are a member of Mozilla
Bugs, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/303269

Title:
  Automatically select language for spell check based on user input

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/303269/+subscriptions