[Bug 744580]

Roc-ocallahan 744580 at bugs.launchpad.net
Sat Apr 2 12:07:51 UTC 2011


+  nscoord oneDevPixel = presContext->DevPixelsToAppUnits(1);
+  nsPoint offsetPoint = aPoint - nsPoint(oneDevPixel * 20, oneDevPixel * 20);
+  nsSize rectSize = nsSize(oneDevPixel * 40, oneDevPixel * 40);
   PRBool didScroll = presContext->PresShell()->
+    ScrollFrameRectIntoView(aFrame, nsRect(offsetPoint, rectSize),

Why not
  nsRect r = nsIntRect(-20, -20, 40, 40).
    ToAppUnits(presContext->AppUnitsPerDevPixel());
  PRBool didScroll = presContext->PresShell()->
    ScrollFrameRectIntoView(aFrame, r + aPoint);

Sure looks simpler to me!

-- 
You received this bug notification because you are a member of Mozilla
Bugs, which is subscribed to Mozilla.
https://bugs.launchpad.net/bugs/744580

Title:
  Firefox doesn't auto scroll when selecting content downwards




More information about the Ubuntu-mozillateam-bugs mailing list