[Bug 195929] Re: Cosmetic bug: rectangular white outline surrounding rounded buttons

[Conn]

Alexander,

Take a look at two shots taken from Firefox 3 on http://slashdot.org.
The first shows the widgets rendered by the default (unpatched) Human
theme using the Ubuntulooks engine, and and second shot shows the
patched engine. Note that the same problem exists for the Murrine
engine, but there's no need for duplicate shots.

As you can see in the unpatched engine, there is a white rectangular
border surrounding widgets, giving them an ugly appearance on a non-
white or non-grey background. Even though buttons are rounded in the
Human theme, this rectangular border looks ugly even if the button
radius/roundness is set to 0 in a theme's gtkrc.

The patched engine fixes GtkButton widgets (see the "Log in" button in
the picture), but not GtkEntry widgets, unfortunately. We need to wait
for a fix in Firefox and/or GTK for GtkEntry cases. See Firefox
upstream's bug here: https://bugzilla.mozilla.org/show_bug.cgi?id=405421

Andrea Cimitan found an old workaround specific for earlier Firefox
versions in his Murrine engine, as evident from the comment in the code:
"// Fix some firefox crap.". Andrea has fixed this upstream, but has not
backported the change to Hardy's version. I posted the proper patch for
Hardy's gtk2-engines-murrine in comment #8. I also checked the
Ubuntulooks and found the identical hack present in the code, so I
uploaded a patch in comment #10 for Hardy's gtk2-engines-ubuntulooks
package.

In summary, this is the action I propose to take:
For Hardy: apply the patches to gtk2-engines-murrine (comment #8) and gtk2-engines-ubuntulooks (comment #10).

For Intrepid: Kenneth Wimer has already packaged Murrine from SVN, so no
patch is necessary. Kenneth also mentioned that he plans to remove gtk2
-engines-ubuntulooks and the Human theme, replacing it with his new dark
theme and a newer version of Human-Murrine that I sent to him, both of
which will use the Murrine engine. Therefore, no patches are necessary
for Intrepid, but we should keep an eye on the upstream Firefox issue.

** Attachment added: "Ubuntulooks widgets rendered in Firefox 3 (unpatched)"
   http://launchpadlibrarian.net/15069704/Ubuntulooks_widgets_default.png

-- 
Cosmetic bug: rectangular white outline surrounding rounded buttons
https://bugs.launchpad.net/bugs/195929
You received this bug notification because you are a member of Mozilla
Bugs, which is subscribed to firefox in ubuntu.