fonts-yas

[Steve Langasek]

Hi,

Thanks for your interest in contributing to Ubuntu and improving Persian
support for our users!

I notice the branch in question is a bzr branch.  Most Ubuntu code nowadays
is maintained in git, or does not use a version control system.  Was there a
particular reason you put this into bzr?  (If you were following some Ubuntu
documentation, for example, I would like to know which documentation, so we
can improve it.)

Your package uses what's referred to as a "non-native" version number, where
there is an upstream part ("4.0") and a Debian revision ("1").  Three points
on this:

- This means the package should include an upstream tarball.  Is an upstream
  tarball available somewhere for these fonts?  I've checked
  https://gitlab.flossir.org/farsi-fonts/yas/-/releases and don't see any.
  There are references to 'irmug.org' in the source but this doesn't appear
  to be a current domain for anything related.
- If there is an upstream tarball, then debian/watch should exist and tell
  where to find it.
- The Debian revision for an Ubuntu package should be -0ubuntu1, rather than
  1.

I could give other feedback about the packaging, but these are probably the
points to address first.

Also, if you don't have a specific reason to use bzr, it is probably going
to be easier to review a package if you build it and upload it to a PPA:
https://help.launchpad.net/Packaging/PPA

On Fri, Aug 19, 2022 at 11:35:56PM +0430, A. Shafiei wrote:
> Hello everyone,
> 
> There are a number of fonts for Persian language which I am trying to
> package. The first one is the Yas font.
> 
> I would like to know if anyone could please review this package:
> https://code.launchpad.net/~r-shf/+junk/fonts-yas
> 
> Thanks in advance.
> A. Shafiei


-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-motu/attachments/20220819/8683909f/attachment.sig>