Request for review

[Robert Park]

On Thu, Jul 26, 2012 at 3:29 PM, Benjamin Drung <bdrung at ubuntu.com> wrote:
>> Yes in theory, however I've been following a few other people's
>> request for sponsorship in debian-mentors and it seems nearly
>> impossible to get sponsorship during the freeze, because nobody cares
>> about new packages and everybody is busy testing the frozen 'testing'
>> distro.
>
> Getting sponsors is sometimes complicated due to missing man power, but
> I doubt that this is connected to the freeze.

Alright, well I'll give it a shot soon, once I have the package a bit
more cleaned up.

> It's my opinion, that debian/changelog should only contain entries for
> uploads to Debian. IMO every new upload to Debian should add only one
> new block in the changelog file. Having entries like "gottengeography
> (1.1-2) unstable; urgency=low" are misleading, because they were never
> uploaded to unstable. It should at least detectable, what versions were
> uploaded to Debian and which were uploaded somewhere else.

I see where you're going with this. I guess I will truncate it then.
Originally I was concerned about "losing" so much "information", but
really the git changelog on github is always going to be there, so a
truncated changelog file isn't a big deal at all then.

> Not every change there looks like a needed packaging change. Example:
>
> --- gottengeography-2.1.orig/gg/version.py
> +++ gottengeography-2.1/gg/version.py
> @@ -8,7 +8,7 @@
>
>  APPNAME='GottenGeography'
>  PACKAGE='gottengeography'
> -VERSION='2.0'
> +VERSION='2.1'

Well, this is quite embarrassing ;-)

You see, I shipped the 2.1 upstream tarball with the version defined
as 2.0 (ie, I forgot to update the version string before releasing the
tarball). I know it's frowned upon to change a release after it's in
the wild, and I didn't think it would be unacceptable to simply
correct this in the debian package, so that's why that patch is there.

I'm currently working on unifying as much as possible the 'master' and
'debian' branches, in the hopes that indeed there can be no patches
and you can just drop the 'debian/' folder into the upstream tarball
and build a package.

Thanks again!

-- 
http://gottengeography.ca