[ubuntu-mono] [Bug 691573] Re: Rio Karma support disabled until libkarma can enter main

[Kamus]

** Changed in: banshee (Ubuntu)
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Ubuntu
CLI/Mono Uploaders, which is subscribed to banshee in Ubuntu.
https://bugs.launchpad.net/bugs/691573

Title:
  Rio Karma support disabled until libkarma can enter main

Status in “banshee” package in Ubuntu:
  Confirmed
Status in “libkarma” package in Ubuntu:
  Confirmed

Bug description:
  Binary package hint: banshee

  During the MIR for banshee (bug 607291), it came up that libkarma is
  sort of a mess:

  """
   * lintian messages:

  E: libkarma source: patch-modifying-debian-files 20_install_playlist_show_as_example.dpatch debian/libkarma-dev.examples
  W: libkarma source: patch-system-but-no-source-readme
  W: libkarma source: patch-system-but-direct-changes-in-diff tools/karma_helper.c
  W: libkarma source: debhelper-but-no-misc-depends libkarma-dev
  W: libkarma source: out-of-date-standards-version 3.8.0 (current is 3.9.1)
  W: libkarma-cil: wrong-section-according-to-package-name libkarma-cil => cli-mono
  W: libkarma-cil-dev: wrong-section-according-to-package-name libkarma-cil-dev => libdevel

   * A watch file (and homepage setting) that 404s

   * No symbols file or -V arg to dh_makeshlibs

   * Bug 296737 seems bad

   * New upstream version available but unpackaged for 3 and a half
  years

   * A bad memcpy and strncat for amd64:

  In file included from /usr/include/string.h:642:0,
                   from karmaLan.c:18:
  In function ‘memcpy’,
      inlined from ‘lk_karmaLan_get_protocol_version’ at karmaLan.c:198:11:
  /usr/include/bits/string3.h:52:3: warning: call to __builtin___memcpy_chk will always overflow destination buffer

   * Lots of errors like the following representative sample:

  properties.c:350:18: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result
  properties.c:296:9: warning: ignoring return value of ‘read’, declared with attribute warn_unused_result
  mp3.c:206:18: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result
  riocp.c:652:22: warning: ignoring return value of ‘scanf’, declared with attribute warn_unused_result
  karma.c:49:5: warning: ISO C90 forbids specifying subobject to initialize

   * And to top it off, upstream no longer has a working Karma and is looking for a new maintainer, so no new fixes from that direction.
  ""

  So I've disabled libkarma support in banshee so that it can enter
  main.  When these issues are fixed, we should refile a MIR for
  libkarma and re-enable support for it.