[ubuntu-mono] [Bug 683617] Re: Should not show tab in Properties window, when there is only one tab

[Buttink]

This is all that should be needed for the simple fix


git diff
diff --git a/src/Core/Banshee.ThickClient/Banshee.Gui.TrackEditor/TrackEditorDia
index 949489b..8290213 100644
--- a/src/Core/Banshee.ThickClient/Banshee.Gui.TrackEditor/TrackEditorDialog.cs
+++ b/src/Core/Banshee.ThickClient/Banshee.Gui.TrackEditor/TrackEditorDialog.cs
@@ -257,6 +257,10 @@ namespace Banshee.Gui.TrackEditor
             if (page_to_focus != null) {
                 notebook.CurrentPage = notebook.PageNum (page_to_focus);
             }
+
+            if (pages.Count < 2) {
+                notebook.ShowTabs = false;
+            }
         }
 
         private void BuildFooter ()
diff --git a/src/Hyena b/src/Hyena
--- a/src/Hyena
+++ b/src/Hyena
@@ -1 +1 @@
-Subproject commit 507573f2b0b1a462df491bb236bba9a3e86e2869
+Subproject commit 507573f2b0b1a462df491bb236bba9a3e86e2869-dirty


I'd do it myself, but I'm having problems with autoconf and can't run it to test it. Another solution would be to have the same Dialog for both, but just make "Properties" start on the "Properties" tab.

-- 
You received this bug notification because you are a member of Ubuntu
CLI/Mono Uploaders, which is subscribed to banshee in ubuntu.
https://bugs.launchpad.net/bugs/683617

Title:
  Should not show tab in Properties window, when there is only one tab

Status in Banshee Music Player:
  Unknown
Status in One Hundred Paper Cuts:
  Triaged
Status in “banshee” package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: banshee

(real bug is https://bugzilla.gnome.org/show_bug.cgi?id=615797 but filing it here too so we can track it as a papercut)

The track properties dialog sports a tabbed interface, but there is only one tab, so that looks odd and it makes it not really a tabbed interface. It also looks a bit odd.

This is probably happening because it's pretty much shares everything with the Edit Track dialog, including this tab.

We probably should special case a single tab.