[Bug 328604] Re: system-config-printer shouldn't use notifications with actions
Martin Pitt
martin.pitt at ubuntu.com
Wed Mar 4 22:07:18 GMT 2009
Ken,
your patch seems to miss more than half of David's patch; it seems that
your debdiff changes an existing debian/patches/26_notification.patch,
but the current jaunty package doesn't have that.
Why did you do this mv $(CURDIR)/debian/tmp/usr/local/lib
$(CURDIR)/debian/tmp/usr/? That looks fishy, and obviously wasn't
required before.
While you are at it, could you please fix
os.environ['GDMSESSION'] -> os.environ.get('GDMSESSION')
? I already pointed that out above, but seems to have slipped (we don't
want the program to crash with a KeyError if $GDMSESSION isn't defined
at all). Thanks!
--
system-config-printer shouldn't use notifications with actions
https://bugs.launchpad.net/bugs/328604
You received this bug notification because you are a member of Ubuntu
Sponsors for main, which is a direct subscriber.
More information about the Ubuntu-main-sponsors
mailing list