Patch for bug 504918

Matthew East mdke at ubuntu.com
Sun Jan 17 11:01:58 UTC 2010


Hi Andrew,

On Sun, Jan 17, 2010 at 8:58 AM, Andrew Rowell <epic93dude at gmail.com> wrote:
> I have attached the xml file which includes the fix to bug 594918.

Thanks for this. For others' context we are talking about bug 504981.
A bit of feedback:

1. If possible you should submit a patch or a bzr bundle rather than
the whole xml file - you'll find instructions here:
https://wiki.ubuntu.com/DocumentationTeam/SystemDocumentation/Submitting

2. I don't think the point of the bug is that java needs to be
installed prior to installing ubuntu-restricted-extras. If you look at
the bug referred to (bug 359934) think the point is that installing
ubuntu-restricted-extras will now automatically bring in
sun-java6-plugin when ubuntu-restricted-extras is installed. So what
needs to be done is to add that to the list of plugins which are
installed by ubuntu-restricted-extras.

3. Just in terms of grammar, the word "Check" shouldn't be
capitalised. Also, you've written "sun-java6-package" instead of
"sun-java6-plugin package".

Feel free to have a go at another patch and attach it to the bug report.

-- 
Matthew East
http://www.mdke.org
gnupg pub 1024D/0E6B06FF




More information about the ubuntu-doc mailing list