Fwd: layout change for help center

[hv1989]

Hi,

I have worked a little bit further. Now I have implented the small icons on
the toolbars, like you suggested. I made it a little better, by making it
possible to choose it in gconf-editor. Default it will show the icon only
toolbar. But everyone can choose to change it in gconf-editor;-).

file: ./src/yelp-window.c
(at the beginning: line~70)
add:
  /* gconf-editor */
  #define KEY_YELP_DIR            "/apps/yelp"
  #define KEY_YELP_TOOLBARE_STYLE KEY_YELP_DIR "/toolbar_style"

  static GConfClient *gconf_client = NULL;
  /* // */

file: ./src/yelp-window.c
function: window_populate()
search (~line 1278):
    gtk_toolbar_insert (GTK_TOOLBAR (toolbar), GTK_TOOL_ITEM (f_proxy), 0);
    gtk_toolbar_insert (GTK_TOOLBAR (toolbar), GTK_TOOL_ITEM (b_proxy), 0);
add after:
    /* set icon only, but let it configurable through gconf-editor */
    /* FIXME: don't change if yelp is open (use gconf_client_notify_add)*/
    gconf_client = gconf_client_get_default ();
    gconf_client_add_dir (gconf_client, KEY_YELP_DIR,
              GCONF_CLIENT_PRELOAD_ONELEVEL, NULL);
    if(!gconf_client_get_int (gconf_client, KEY_YELP_TOOLBARE_STYLE, NULL))
    {
        gconf_client_set_int (gconf_client,
                   KEY_YELP_TOOLBARE_STYLE,
                   GTK_TOOLBAR_ICONS, NULL);
    }
    gtk_toolbar_set_style(GTK_TOOLBAR (toolbar), gconf_client_get_int
(gconf_client, KEY_YELP_TOOLBARE_STYLE, NULL));



On 2/28/07, Matthew Paul Thomas <mpt at myrealbox.com> wrote:
>
> [sent back to the list]
>
> On Mar 1, 2007, at 7:08 AM, hv1989 wrote:
> > ...
> > I appreciate your comments, although one of them isn't correct. You
> > are saying my version takes more place than the old one. That isn't
> > correct. The old side bar is 15px bigger than the one of me.
>
> But the window would be more compact if we didn't have a sidebar at
> all. This is already true when reading man pages, for example. If the
> search field was put in the sidebar as you have done it, either the
> sidebar would need to be visible all the time, or the search wouldn't
> be available while you were reading a page that didn't have a table of
> contents.
>
> > ...
> > Also I think there's a difference, between changing the layout of the
> > article and changing the layout of the application. What I mean is I'm
> > busy with how the application look like. Not the layout of the content
> > of yelp. And for the moment is the layout of the whole application
> > more importent than the layout of the content. So if I get this
> > realised I while definitly help with spacing the lists.
> > ...
>
> Ah, if you want to change yelp itself, I have some suggestions there
> too. :-) I think it would be an improvement if the toolbar was always
> icons-only (so that the window is more compact), the "Search" field was
> aligned with the right end of the toolbar, and the search field shrank
> rather than disappearing when the window became narrower.
>
> Cheers
> --
> Matthew Paul Thomas
> http://mpt.net.nz/
>
>
> --
> ubuntu-doc mailing list
> ubuntu-doc at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/ubuntu-doc
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/ubuntu-doc/attachments/20070301/bddc43d1/attachment.html>