Breaking up the importer's huge icommon.py file

Max Bowsher maxb at f2s.com
Sat May 21 17:52:20 UTC 2011


A huge amount of the UDD importer's interesting code is in one file,
icommon.py.

I'd like to submit a series of changes to break it up such that only the
most common bits of code remain there.

Things I'm thinking of:

1) Move code in icommon.py that is uniquely invoked by a single
executable component of the importer out to that component:

e.g.
class ImportList, class PackageToImport --> import_package.py

class SubprocessMonitor, class ThreadDriver --> mass_import.py

load_explanations --> categorise_failures.py

2) Where a category of code with a single theme exists, move it from
icommon.py to a new file - e.g.:

move all code dealing with the Launchpad API to a new ilpapi.py.

move all code dealing with sqlite dbs to a new idatabase.py.



Assuming the idea is liked, I think the best way to proceed would be for
me to do a single one of these moves, merge-propose it, wait for
approval, land it, and repeat the cycle until done.

This should minimize clashing with other branches trying to land, and
potentially awkward merges.


Max.




-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/ubuntu-distributed-devel/attachments/20110521/3ee534ed/attachment.pgp>


More information about the ubuntu-distributed-devel mailing list