Terminating the append_revisions_only experiment, for now

[James Westby]

On Tue, 23 Aug 2011 09:41:24 +0200, vila <v.ladeuil+lp at free.fr> wrote:
> This is also very close to my feelings and I like to add that we should
> *really* write tests to capture them and make sure we don't regress
> again in the future.
> 
> Overall, I feel we have far too much failures when landing *good* stuff
> *because* we lack a proper way to test. It's a long known issue that we
> miss a launchpad test server but *not* having tests to guard against
> regressions is clearly a path we don't want to pursue as demonstrated
> here (IMNSHO).
> 
> Whether we address that by using staging or any sort of local launchpad
> test server is open to discussion but the sooner we start this
> discussion the better.

I think there are tests that could be written that would have caught
some of these issues that don't require a Launchpad instance to run.

There are problems when the append-revisions-only is set on the local
branches for instance.

Whether the code is structured such that you can test those code paths
without a Launchpad instance is a different matter though :-)

I'm not saying that we shouldn't work out a way to test against
Launchpad, just that there may be useful things that can be done without
solving that problem.

Thanks,

James