First impressions (long)

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Barry Warsaw wrote:
> The only thing we're missing is the combine-and-drop-down command, meaning
> "combine the top three threads into the new patch thread".

bzr-loom isn't really missing that.  The top thread is already the
combination of all threads beneath it, (if you've run up-thread -a).  So
literally, the command you describe is "create-thread".

> bzr combine-thread
> isn't it -- I don't trust that command at all because I think it throws away
> everything in the thread when it gets rid of it.

It doesn't do anything nefarious-- it just deletes the thread.  The
revision that the thread referred to will still exist in the repository.
 And if you have taken snapshots, the thread will exist in them.

> combine-thread /could/ be
> that thing if it did a merge without losing the changed in the current thread,
> and would refuse to combine down past say the last locked thread.

I think it's simpler to just have combine-thread object if asked to
delete a thread that is not fully merged into the upper thread.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAksntJAACgkQ0F+nu1YWqI3pfQCfQwXRKJ1nXAG3DviQr2/xkKzo
X3gAn2XPOcIkmP3sCWiVY/sqXSo0mqgy
=d6dU
-----END PGP SIGNATURE-----