+1 maintenance report

[Heather Ellsworth]

On 7/7/21 4:30 AM, Matthias Klose wrote:
> On 7/6/21 5:07 PM, Heather Ellsworth wrote:
>> June 28 - July 2 (with 1.5 days afk to take care of a sick kiddo)
>>
>> Last week I worked on a few packages:
>>
>> * libpam-alreadyloggedin
>> Ubuntu pulls this package from sid and distributes it without modification.
>> Debian sid ships gcc 10.2.1 and this package will build on ubuntu with this
>> version. However, in gcc-10 version 10.3.0-4ubuntu1, the __xstat function usage
>> has changed causing this failure. I tried further debugging of gcc-10 and got
>> lost so moved on.
> 
> it might be popular with some developers, but please resist the urge to blame
> the compiler for everything ;)

I just meant that gcc is daunting and I went down one path to debug it, 
it was the wrong path, and I didn't know where to go from there.

So thank you for nudging me in the right direction :)

> in impish the package is built using -DBUG_STAT_MISSING
> 
> when built in hirsute, it's built using "-DBUG_STAT_MISSING -Wdate-time
> -D_FORTIFY_SOURCE=2 -D_FILE_OFFSET_BITS=64 -UBUG_STAT_MISSING".
> 
> The conflicting values are in debian/rules and the makefiles patch.
> 
> Please find out what value should be passed.  Bonus points for finding out what
> changed in impish compared to hirsute to pass the additional flag.

Turns out that the debian/rules was overhauled to use the dh sequencer 
and with those deleted lines was the -D_FILE_OFFSET_BITS=64 and 
-UBUG_STAT_MISSING. The file offset one is only needed for 32 bit 
systems so I left that off. Hirsute was passing only because it was 
defining and then undefining BUG_STAT_MISSING in the same gcc line.

Anyways, thanks so much for your guidance.

Upstream bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=990833
Launchpad bug: 
https://bugs.launchpad.net/debian/+source/libpam-alreadyloggedin/+bug/1935081
PR: 
https://salsa.debian.org/debian/libpam-alreadyloggedin/-/merge_requests/1

Cheers,
Heather