Rewriting update-maintainer

[Benjamin Drung]

Am Freitag, den 17.12.2010, 15:45 -0800 schrieb Kees Cook:
> Hi,
> 
> On Fri, Dec 17, 2010 at 11:25:01PM +0100, Benjamin Drung wrote:
> > I am going to rewrite update-maintainer (it's in the ubuntu-dev-tools
> > package) to use python-debian. Looking at the current version, I am not
> > sure what this tool should exactly do.
> 
> This is what the security team uses:
> http://bazaar.launchpad.net/~ubuntu-security/ubuntu-security-tools/trunk/annotate/head%3A/build-tools/u-maint
> 
> > 1) Check if "ubuntu" is in the Debian version. Go on to the next step if
> > yes, otherwise say "Not an Ubuntu package - Nothing to do." and exit.
> 
> I took the option of examining the release name instead (line 23), since
> there are packages that are ubuntu-native and don't carry "ubuntu" in the
> version.

I adopted the release name check and expanded it to detect unstable*,
testing*, and stable*.

> > 2) Check if the Maintainer email address has a "@ubuntu.com" or
> > "@lists.ubuntu.com". Go on to the next step if no, otherwise say
> > "Already maintained by Ubuntu" and exit.
> 
> This seems to catch most stuff: @([^\.]+\.)*(launchpad.net|ubuntu.com)
> (lines 26 through 31)

I modified the check to allow everything that ends with ubuntu.com. Do
we really want to allow @*.launchpad.net?

> > 3) Move the maintainer from the "Maintainer" to
> > "XSBC-Original-Maintainer" field and set "Ubuntu Developers
> > <ubuntu-devel-discuss at lists.ubuntu.com>" as new Maintainer.
> 
> This depends on the component target, so you need to look that up first
> (lines 33 through 42).

Not any more (as discussed earlier).

> > Did I oversee something? Is there a use case that is not covered? Any
> > other comments? If I receive no comments, I will JFDI [1] and release it
> > with the next upload of ubuntu-dev-tools.
> 
> It needs to detect and update control.in files too (lines 18 through 21).

Yes, it does tries control.in in the control.

-- 
Benjamin Drung
Debian & Ubuntu Developer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <https://lists.ubuntu.com/archives/ubuntu-devel/attachments/20110127/718321d4/attachment.pgp>