Rewriting update-maintainer

Kees Cook kees at ubuntu.com
Fri Dec 17 23:45:25 UTC 2010


Hi,

On Fri, Dec 17, 2010 at 11:25:01PM +0100, Benjamin Drung wrote:
> I am going to rewrite update-maintainer (it's in the ubuntu-dev-tools
> package) to use python-debian. Looking at the current version, I am not
> sure what this tool should exactly do.

This is what the security team uses:
http://bazaar.launchpad.net/~ubuntu-security/ubuntu-security-tools/trunk/annotate/head%3A/build-tools/u-maint

> 1) Check if "ubuntu" is in the Debian version. Go on to the next step if
> yes, otherwise say "Not an Ubuntu package - Nothing to do." and exit.

I took the option of examining the release name instead (line 23), since
there are packages that are ubuntu-native and don't carry "ubuntu" in the
version.

> 2) Check if the Maintainer email address has a "@ubuntu.com" or
> "@lists.ubuntu.com". Go on to the next step if no, otherwise say
> "Already maintained by Ubuntu" and exit.

This seems to catch most stuff: @([^\.]+\.)*(launchpad.net|ubuntu.com)
(lines 26 through 31)

> 3) Move the maintainer from the "Maintainer" to
> "XSBC-Original-Maintainer" field and set "Ubuntu Developers
> <ubuntu-devel-discuss at lists.ubuntu.com>" as new Maintainer.

This depends on the component target, so you need to look that up first
(lines 33 through 42).

> Did I oversee something? Is there a use case that is not covered? Any
> other comments? If I receive no comments, I will JFDI [1] and release it
> with the next upload of ubuntu-dev-tools.

It needs to detect and update control.in files too (lines 18 through 21).

-Kees

-- 
Kees Cook
Ubuntu Security Team



More information about the ubuntu-devel mailing list