[Bug 397144] [NEW] Update-Maintainer silently fails when Maintainer-Field contains a comment in brackets

[Andreas Moog]

Public bug reported:

Binary package hint: ubuntu-dev-tools

When the maintainer-field contains brackets, update-maintainer silently
fails to set the maintainerfield.

I discovered this when working on the package "hercules":

Source: hercules
Section: otherosfs
Priority: extra
Maintainer: Peter De Schrijver (p2) <p2 at debian.org>
 
The comment "(p2)" results in update-maintainer to fail when writing the new file, because this:

debian_control_file.write(re.sub(original_maintainer, final_addition,
file_contents))

treats the "()" as part of the regular expression. By rewriting the line
to:

debian_control_file.write(re.sub(re.escape(original_maintainer),
final_addition, file_contents))

this does not happen anymore.

** Affects: ubuntu-dev-tools
     Importance: Undecided
         Status: New

** Affects: ubuntu-dev-tools (Ubuntu)
     Importance: Low
         Status: Confirmed

** Changed in: ubuntu-dev-tools (Ubuntu)
   Importance: Undecided => Low

** Changed in: ubuntu-dev-tools (Ubuntu)
       Status: New => Confirmed

** Also affects: ubuntu-dev-tools
   Importance: Undecided
       Status: New

-- 
Update-Maintainer silently fails when Maintainer-Field contains a comment in brackets
https://bugs.launchpad.net/bugs/397144
You received this bug notification because you are a member of Ubuntu
Development Team, which is the registrant for Ubuntu Developer Tools.