minor cdimage bug?
Colin Watson
cjwatson at ubuntu.com
Fri Jun 13 17:18:27 BST 2008
On Wed, Jun 11, 2008 at 01:16:14PM -0500, Josh Cronemeyer wrote:
> I can't find a bug tracker for the cdimage tool so I'm posting to these
> lists.
(Matt answered this correctly.)
> I've been using cdimage to generate my own customized xubuntu installer. I
> was having an issue getting changes in my local seeds to propigate through
> to the tasks. I figured it out and wanted to mention the behavior I was
> getting to the community in case this was a bug.
>
> 1. If you set the LOCAL_SEEDS env var and the path you specify is not a
> bzr branch you get an error. I was thinking the local seeds shouldn't
> have to be a bzr branch.
>
> 2. If you set the LOCAL_SEEDS env var to a directory that is a bzr branch,
> but one that has uncommitted local changes, the germinate command will
> ignore your uncommitted local changes and just use the latest version from
> the repository. I was thinking it shouldn't ignore uncommitted local
> changes.
>
> The following diff is an easy workaround for this:
>
> === modified file 'bin/run-germinate'
> --- bin/run-germinate 2008-04-30 21:53:12 +0000
> +++ bin/run-germinate 2008-06-11 17:26:44 +0000
> @@ -23,6 +23,7 @@
> fi
> if [ "$LOCAL_SEEDS" ]; then
> SEED_SOURCE="$LOCAL_SEEDS"
> + GERMINATE_BZR=
> fi
>
> case $DIST in
I think this is reasonable, and have applied your patch with the
addition of a comment on why it's there. Thanks!
--
Colin Watson [cjwatson at ubuntu.com]
More information about the ubuntu-devel
mailing list