Accepted xresprobe 0.4.24ubuntu1 (source)

[Matt Zimmerman]

On Wed, Mar 07, 2007 at 08:45:49PM +0200, Timo Aaltonen wrote:
> On Wed, 7 Mar 2007, Matt Zimmerman wrote:
> 
> > On Wed, Mar 07, 2007 at 02:25:40PM -0000, Timo Aaltonen wrote:
> >>  xresprobe (0.4.24ubuntu1) feisty; urgency=low
> >>  .
> >>    * lcdsize.sh:
> >>      - Add support for vesa.
> >
> > The vesa driver isn't able to probe panel sizes, is it?
> 
> Not like the other drivers are, but it still can detect the display size 
> (well, whatever vesa supports). This is what I added to lcdsize.sh (and 
> tested with a Thinkpad Z61p, which has a r5xx ATI chip):
> 
> -----
>     EGREPLINE="\(--\) CHIPS\(.*\): Display Size: x=.*; y=.*"
>     SEDLINE="s/(--) CHIPS([^)]*): Display Size: x=\([^;]*\); y=\([^ ]*\)/\1x\2/;"
>     getres
> +elif [ "$DRIVER" = "vesa" ]; then
> +  EGREPLINE="\(--\) VESA\(.*\): Virtual size is .*x.*"
> +  SEDLINE="s/(--) VESA([^)]*): Virtual size is \([^x]*\)x\([^ ]*\)/\1x\2/;"
> +  getres
>   else
>     exit 1
>   fi
> -----
> 
> ('getres' was missing from ubuntu1, but a new version is coming..)
> 
> could be that "Virtual size" isn't the best string to match..

Does this provide us with any useful information?  Does the VESA BIOS
accurately report the size of an attached LCD?

> >>    * xprobe.sh:
> >>      - Don't use the bare-bones config, instead rely on the new xserver
> >>        to be clever.
> >
> > This sounds like a change with potentially many hardware-specific effects.
> > Can you explain a bit more?
> 
> That's correct, but this can be reverted easily before the beta if it 
> creates more problems than it solves.

No, I don't think it can.  The beta freeze is next week, and the beta
release the week after.  I don't think this can be credibly tested before
then.  We simply won't know whether it breaks too much until huge numbers of
people try the beta.

This is why changes which require extensive testing like this need to be
made early in the release cycle, and the freeze guidelines are meant to
provide guidance on these choices.

> The old version probes with a config that has a 'Mode "1024x768"' set, 
> which means that the string I'm trying to match with vesa would be just 
> that (->no progress).

There were no bug numbers included in the changelog, so it isn't clear what
problem you're attempting to solve.  Perhaps if you discuss it here on the
list, we can come to a consensus about the best way to proceed.

-- 
 - mdz