ext2_types.h in package e2fslibs-dev is whacked

[Colin Watson]

On Sat, Jan 07, 2006 at 01:29:10AM -0500, Phillip Susi wrote:
> I just found this header because I'm trying to get the defrag package to 
> compile from source on amd64, and this thing is insane.  First off, it 
> seems to duplicate definitions of basic data types that are already 
> defined in asm/types.h, but it does so wrongly.  Take a look at this:
> 
> #if (4 == 2)
> typedef    int        __s16;
> typedef    unsigned int    __u16;
> #else
> 
> WTF?  How many drugs over what period of time would you have to consume 
> for 4 to equal 2?
> 
> Where did this craziness come from

Firstly, please relax and turn your flame switch off before posting to
this list.

Secondly, ext2_types.h is generated from ext2_types.h.in, and the
relevant part looks like this:

#if (@SIZEOF_INT@ == 2)
typedef int             __s16;
typedef unsigned int    __u16;
#else

The header won't say "4" there on all architectures, and that #if branch
is never relevant to any Ubuntu architectures.

> and can we please nuke it?

No. It's upstream code and it works perfectly well.

-- 
Colin Watson                                       [cjwatson at ubuntu.com]