acpitool: MOTU, the first blood

[Reinhard Tartler]

On 5/29/05, Emil Oppeln-Bronikowski <opi at cyb3r.org> wrote:
> On Sunday 29 of May 2005 08:47, Daniel Holbach wrote:
> 
> > I think telling people to pick a random repository and install random
> > stuff is wrong.
> 
>  I know that. I did that around 3-4 AM, so I didn't do The Right Thing.
> 
> >  http://www.ubuntulinux.org/wiki/MOTUNewPackages
> 
>  Allready there. ;-)

I have taken a look at your source package. Your build dependencies
are way to strict, please don't include any package with priority
"required" such as gcc or libstdc++, as you can expect the buildd's to
have them installed. Also, plase try to get your package lintian
clean, that means without any Errors or Warings from lintian (there
are both).

Your package build cleanly with gcc-4, so there is no reason to
prohibit that in debian/control.

I didn't really try your package out, but looking at the source, it
seems that toshiba laptops are better supported than other acpi
implementations. Please improve your package description what this
package does, its main features and why should the user/the system
administrator have it installed. A simple "AcpiTool is (yet another)
Linux ACPI client." is way too vague.

If you have any questions, please join us at #ubuntu-motu and ask. You
may ping me again if you want me to rereview your package.

-- 
regards,
    Reinhard