What do do when there's no .dropped (Was: pppoeconf resync)

[Scott James Remnant]

On Mon, 2004-11-15 at 16:46 +0100, Matthias Klose wrote:

> just wondering why I get this offered for review. All patches seem to
> appply cleanly.
> 
Check that the ubuntu.{patch,debdiff} and merged.{patch,debdiff} are
"identical".  Where things are missing from the merged patch, check that
the result is in the source package -- if so, this is a result of Debian
applying our patches.

Make sure they did it right, and didn't drop anything.

If things are actually missing, comment on the bug because you've found
a problem with mom.

Check it didn't do anything stupid like duplicate functions -- this is
sadly unavoidable when people use stupid brace-styles that leave only:

	}
	else
	{

in the patch context :-(

These either show up as extra things in the merged patch, that weren't
in the ubuntu patch, or more usually just as a build failure.


Often (as is the case with pppoeconf) there's some dirty in the .po
files; check that no translations or branding have been dropped, in your
case it just looks like msgcat/msgmerge reformatted the .po file -- so
you're ok there.


If you're entirely happy with the new source package, grab it, generate
a changes file using the command given in REPORT (which includes the
right changelog entries), sign it (and the dsc file) and upload it.

Scott
-- 
Scott James Remnant
scott at canonical.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.ubuntu.com/archives/ubuntu-devel/attachments/20041115/2ce7606a/attachment.pgp