Where can I feedback to package avahi-daemon?

Sat Apr 4 18:01:34 UTC 2020

Hey Trent,

thank you for getting back at me! You know what's funny? Now I had to
dig a bit to recover my finding. :-)

OK, the main point you can see in diff-1.patch: here the command
substitutions are used in a wrong way because the shell expects to
execute what the command substitution returned. Example to illustrate
what I mean:

$ sh -c '$(echo "echo PID is $$")'
PID is 17168

diff-2.patch contains some changes that simplify, replace backticks
for the modern form of Command Substitution and get rid of a check of
$? vs. a direct check of exit status in the if condition.

I have also attached the base version against which patches were done.
This is from Xubuntu 18.04.

I filed the error as a bug against Ubuntu ahavi so it can be properly tracked:
https://bugs.launchpad.net/ubuntu/+source/avahi/+bug/1870824

The other changes are merely suggestions for improvement. I would
probably do more, but then again we should never touch a running
system. :-)

Kind regards

robert

On Tue, Mar 31, 2020 at 11:15 AM Trent Lloyd <trent.lloyd at canonical.com> wrote:
>
> Hi Robert,
>
> Sorry for the late reply. This script is specific to the Debian/Ubuntu packages and is not upstream. And actually due to libnss-mdns improvements this script is not required in Focal as libnss-mdns automatically determines if a .local domain exists and directs the queries appropriately. The version in 18.04 (Bionic) however does technically still require it.
>
> In terms of how to submit a patch it would be upstream to Debian and/or Ubuntu directly by filing a bug in the relevant packaging systems.
>
>
> I am the maintainer of Avahi upstream but also active in the Ubuntu development and happy to discuss your patches/thoughts/changes - feel free to open a Launchpad bug and we can always curate it and then send it upstream to Debian. The debian maintainers are also fairly responsive.
>
> Regards,
> Trent
>
> On Tue, 25 Feb 2020 at 02:47, Robert Klemme <shortcutter at googlemail.com> wrote:
>>
>> Hi,
>>
>> I think I found something that could be improved in file
>> /usr/lib/avahi/avahi-daemon-check-dns.sh on my Xubuntu 18.04.4. But
>> somehow I cannot seem to find the right place to deliver a patch, pull
>> request or feedback. Via apt-file I found out the file belongs to
>> package avahi-daemon. When downloading the source via "apt source
>> avahi-daemon" it says
>>
>> $ apt source avahi-daemon
>> Reading package lists... Done
>> Picking 'avahi' as source package instead of 'avahi-daemon'
>> NOTICE: 'avahi' packaging is maintained in the 'Git' version control system at:
>> git://anonscm.debian.org/pkg-utopia/avahi.git
>> Please use:
>> git clone git://anonscm.debian.org/pkg-utopia/avahi.git
>> to retrieve the latest (possibly unreleased) updates to the package.
>> Need to get 1.373 kB of source archives.
>> Get:1 http://ubuntu.unitedcolo.de/ubuntu bionic-updates/main avahi
>> 0.7-3.1ubuntu1.2 (dsc) [4.186 B]
>> Get:2 http://ubuntu.unitedcolo.de/ubuntu bionic-updates/main avahi
>> 0.7-3.1ubuntu1.2 (tar) [1.333 kB]
>> Get:3 http://ubuntu.unitedcolo.de/ubuntu bionic-updates/main avahi
>> 0.7-3.1ubuntu1.2 (diff) [35,1 kB]
>> Fetched 1.373 kB in 1s (2.417 kB/s)
>> dpkg-source: info: extracting avahi in avahi-0.7
>> dpkg-source: info: unpacking avahi_0.7.orig.tar.gz
>> dpkg-source: info: unpacking avahi_0.7-3.1ubuntu1.2.debian.tar.xz
>> dpkg-source: info: applying fix-manpage-install-conditions.patch
>> dpkg-source: info: applying man-add-missing-bshell.1-symlink.patch
>> dpkg-source: info: applying
>> man-fix-reference-to-avahi-autoipd.action-8-in-avahi-auto.patch
>> dpkg-source: info: applying no-systemd-also.patch
>> dpkg-source: info: applying local-only-services-support.patch
>> dpkg-source: info: applying CVE-2017-6519-and-CVE-2018-1000845.patch
>>
>> I tried git clone git://anonscm.debian.org/pkg-utopia/avahi.git first but
>>
>> $ git clone git://anonscm.debian.org/pkg-utopia/avahi.git
>> Cloning into 'avahi'...
>> fatal: unable to connect to anonscm.debian.org:
>> anonscm.debian.org[0: 194.177.211.202]: errno=Connection refused
>> anonscm.debian.org[1: 2001:648:2ffc:deb::211:202]: errno=Network is unreachable
>>
>> The system seems up:
>>
>> $ ping -c 4 anonscm.debian.org
>> PING cgi-grnet-01.debian.org (194.177.211.202) 56(84) bytes of data.
>> 64 bytes from cgi-grnet-01.debian.org (194.177.211.202): icmp_seq=1
>> ttl=54 time=63.3 ms
>> 64 bytes from cgi-grnet-01.debian.org (194.177.211.202): icmp_seq=2
>> ttl=54 time=65.2 ms
>> 64 bytes from cgi-grnet-01.debian.org (194.177.211.202): icmp_seq=3
>> ttl=54 time=62.3 ms
>> 64 bytes from cgi-grnet-01.debian.org (194.177.211.202): icmp_seq=4
>> ttl=54 time=63.8 ms
>>
>> --- cgi-grnet-01.debian.org ping statistics ---
>> 4 packets transmitted, 4 received, 0% packet loss, time 3003ms
>> rtt min/avg/max/mdev = 62.336/63.689/65.293/1.067 ms
>>
>> When I checked the .dsc file and try to go to
>> http://anonscm.debian.org/gitweb/?p=pkg-utopia/avahi.git;a=summary I
>> get 404
>>
>> When I look at https://code.launchpad.net/avahi I get pointed to the
>> original repo https://github.com/lathiat/avahi (via
>> https://www.avahi.org/). But in that repo the file does not exist.
>>
>> Now I am confused. What am I missing?
>>
>> Kind regards
>>
>> robert
>>
>>
>> --
>> [guy, jim, charlie, sho].each {|him| remember.him do |as, often|
>> as.you_can - without end}
>> http://blog.rubybestpractices.com/
>>
>> --
>> Ubuntu-devel-discuss mailing list
>> Ubuntu-devel-discuss at lists.ubuntu.com
>> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel-discuss

--
[guy, jim, charlie, sho].each {|him| remember.him do |as, often|
as.you_can - without end}
http://blog.rubybestpractices.com/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: avahi-daemon-check-dns.sh
Type: application/x-shellscript
Size: 4459 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-devel-discuss/attachments/20200404/be2e62a2/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: diff-1.patch
Type: text/x-patch
Size: 887 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-devel-discuss/attachments/20200404/be2e62a2/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: diff-2.patch
Type: text/x-patch
Size: 783 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-devel-discuss/attachments/20200404/be2e62a2/attachment-0002.bin>