systemd samba units

[Nish Aravamudan]

On 03.09.2016 [04:55:13 -0400], Tom H wrote:
> Could Ubuntu ship samba systemd units with the same names as upstream?
> 
> Ubuntu's shipping nmbd, samba (masked), samba-ad-dc, and smbd, whereas
> upstream's shipping nmb, samba (equivalent to samba-ad-dc), and smb.

This seems like a valid request, but maybe worth bringing up to the
Debian maintainers too, as the debian/rules lines that are relevant:

        install -m 0644 packaging/systemd/*.service $(DESTDIR)/lib/systemd/system/
        mv $(DESTDIR)/lib/systemd/system/nmb.service $(DESTDIR)/lib/systemd/system/nmbd.service
        mv $(DESTDIR)/lib/systemd/system/smb.service $(DESTDIR)/lib/systemd/system/smbd.service
        mv $(DESTDIR)/lib/systemd/system/samba.service $(DESTDIR)/lib/systemd/system/samba-ad-dc.service

are, afaict, unchanged from Debian in the current package. Also, it
feels like the naming is mostly due to the fact that the executables are
named the same (/usr/sbin/{s,n}mbd), so manpages, etc. would need
updating correspondingly.

> It'd be helpful and kind to those of who use multiple distros - as
> well as for those who google for documentation.
> 
> It would also prevent the small mistake that's creeped into
> smbd.service: it has "nmb.service" instead of "nmbd.service" in its
> "After=" line.

This probably deserves a bug in Debian/Ubuntu.

        sed -i \
          -e 's|/etc/sysconfig/|/etc/default/|' \
          -e 's|/nmb\.service|nmbd.service|' \
          -e 's|/smb\.service|smbd.service|' \
          -e 's|/samba\.service|samba-ad-dc.service|' \
          $(DESTDIR)/lib/systemd/system/*.service

It seems like the use of a preceding / in the last 3 seds may be an
oversight/c&p error. Again, present in Debian too.

Thanks,
Nish

-- 
Nishanth Aravamudan
Ubuntu Server
Canonical Ltd