Building against libsmbclient-dev:armhf

Colin Watson cjwatson at ubuntu.com
Thu Jun 11 10:01:11 UTC 2015


On Tue, Jun 09, 2015 at 11:31:32AM +0100, Alan Pope wrote:
> # Get source to build
> bzr branch lp:ubuntu-filemanager-app
> 
> # Build it
> Using this script http://paste.ubuntu.com/11667958/ to build
> armhf/amd64/i386 fat package. Fails at first hurdle, the armhf build:-
> 
> http://paste.ubuntu.com/11669092/

ubuntu-filemanager-app is doing a ton of manual work to find
libsmbclient, and the manual work it's doing doesn't look very
multiarch-friendly to me:

  ## samba requires libsmbclient
  find_path(SAMBA_INCLUDE_DIR 
            NAMES libsmbclient.h 
            HINTS /usr/include/smbclient /usr/include/samba /usr/include/samba-3.0 /usr/include/samba-4.0
            )
  find_library(SAMBA_LIBRARIES NAMES smbclient )
  message(STATUS "samba include=${SAMBA_INCLUDE_DIR}")
  message(STATUS "samba lib=${SAMBA_LIBRARIES}=${SAMBA_LIBRARIES}")
  
  if(SAMBA_INCLUDE_DIR AND SAMBA_LIBRARIES)
     message(STATUS "Found samba: include=${SAMBA_INCLUDE_DIR}  library=${SAMBA_LIBRARIES}")
     INCLUDE_DIRECTORIES(${SAMBA_INCLUDE_DIR})
     TARGET_LINK_LIBRARIES(nemofolderlistmodel ${SAMBA_LIBRARIES})
  else(SAMBA_INCLUDE_DIR AND SAMBA_LIBRARIES)
     message(FATAL_ERROR "Could not find Samba libsmbclient")
  endif(SAMBA_INCLUDE_DIR AND SAMBA_LIBRARIES)
  mark_as_advanced(SAMBA_INCLUDE_DIR SAMBA_LIBRARIES)
  ## end samba confiuration

I suspect this would work fine if it did something based on cmake's
pkg-config support instead.

-- 
Colin Watson                                       [cjwatson at ubuntu.com]




More information about the Ubuntu-devel-discuss mailing list