[Merge] ~till-kamppeter/network-manager:master into network-manager:master

[Till Kamppeter]

Till Kamppeter has proposed merging ~till-kamppeter/network-manager:master into network-manager:master.

Commit message:
Backport detecting Wi-Fi FT support per interface, release as 1.20.0-1ubuntu2
    
See https://gitlab.freedesktop.org/NetworkManager/NetworkManager/commit/2f8a4e90f0f


Requested reviews:
  Network-manager (network-manager)

For more details, see:
https://code.launchpad.net/~till-kamppeter/network-manager/+git/network-manager/+merge/372162

This is a backport of the upstream change to not prefer FT-PSK when it is only supported by supplicant but not by the Wi-Fi interface or driver.

>From upstream:

Previously we only cared whether supplicant is build with support for
FT. In that case we would pass FT-PSK to supplicant, like

  Config: added 'key_mgmt' value 'WPA-PSK WPA-PSK-SHA256 FT-PSK'

Supplicant would then always try FT with preference, regardless whether
the interface/driver support it. That results in a failure to associate, if
the driver does not support it.

  NetworkManager[1356]: <info>  [1566296144.9940] Config: added 'key_mgmt' value 'WPA-PSK WPA-PSK-SHA256 FT-PSK'
  ...
  wpa_supplicant[1348]: wlan0: WPA: AP key_mgmt 0x42 network profile key_mgmt 0x142; available key_mgmt 0x42
  wpa_supplicant[1348]: wlan0: WPA: using KEY_MGMT FT/PSK
  ...
  wpa_supplicant[1348]:   * akm=0xfac04
  ...
  kernel: ERROR @wl_set_key_mgmt :
  kernel: invalid cipher group (1027076)

Since we pass a list of acceptable "key_mgmt" options to supplicant,
FT-PSK should not be used when supplicant knows it's not supported.
That is a supplicant bug.

Regardless, work around it by checking the per-interface capability, and
avoid it if support is apparently not present.
-- 
Your team Network-manager is requested to review the proposed merge of ~till-kamppeter/network-manager:master into network-manager:master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 5377 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-desktop/attachments/20190902/ec988215/attachment.diff>