[Merge] ~vanvugt/ubuntu/+source/mutter:fix-lp1763892-bionic into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic

Daniel van Vugt daniel.van.vugt at canonical.com
Fri May 3 08:26:13 UTC 2019


Sorry I keep forgetting to save my inline comments. This is from a few hours ago...

Diff comments:

> diff --git a/debian/libmutter-2-0.symbols b/debian/libmutter-2-0.symbols
> index 1489074..89b3d01 100644
> --- a/debian/libmutter-2-0.symbols
> +++ b/debian/libmutter-2-0.symbols
> @@ -549,6 +549,7 @@ libmutter-2.so.0 libmutter-2-0 #MINVER#
>   meta_gpu_kms_error_quark at Base 3.28.2
>   meta_gpu_kms_flip_closure_container_free at Base 3.28.3+git20190124
>   meta_gpu_kms_flip_crtc at Base 3.28.2
> + meta_gpu_kms_get_current_time_ns at Base 3.28.3+git20190124-0ubuntu18.04.3

The reason it is public seems to be because it is shared between different source files.

I see your point about a '_' prefix but I don't think it's appropriate to go making any such design changes here since the existing form is already in disco and cosmic.

>   meta_gpu_kms_get_fd at Base 3.28.2
>   meta_gpu_kms_get_file_path at Base 3.28.2
>   meta_gpu_kms_get_max_buffer_size at Base 3.28.2


-- 
https://code.launchpad.net/~vanvugt/ubuntu/+source/mutter/+git/mutter/+merge/364362
Your team Ubuntu Desktop is requested to review the proposed merge of ~vanvugt/ubuntu/+source/mutter:fix-lp1763892-bionic into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/bionic.



More information about the ubuntu-desktop mailing list