[Merge] lp:~khurshid-alam/unity-control-center/libnm-port into lp:unity-control-center

Khurshid Alam khurshid.alam at linuxmail.org
Wed May 1 13:57:29 UTC 2019


Khurshid Alam has proposed merging lp:~khurshid-alam/unity-control-center/libnm-port into lp:unity-control-center.

Commit message:
Network: Port to libnm 1.2

Reference: https://bugzilla.gnome.org/show_bug.cgi?id=765910



Requested reviews:
  Sebastien Bacher (seb128)
Related bugs:
  Bug #1744619 in network-manager-vpnc (Ubuntu): "Transitioning GNOME away from libnm-glib"
  https://bugs.launchpad.net/ubuntu/+source/network-manager-vpnc/+bug/1744619

For more details, see:
https://code.launchpad.net/~khurshid-alam/unity-control-center/libnm-port/+merge/366762

This is a direct port from gnome-control-center 3.26. Connection editor & wireless security codes are basically the same. Simply use directory comparison with meld for easier comparison or review.

I would have cherry picked more commits for connection-editor & wifi-security from 3.28/3.30, but in 3.28 they broke away wifi panel and the code is tied with that. But 3.26 is stable and Linux Mint Cinnamon is also using the same. 



PPA: ppa:unity7maintainers/unity7-desktop

Community-Thread: https://community.ubuntu.com/t/testing-of-new-wetwork-panel-in-unity-libnm-port-1-2-eoan/10792

Other details:
---------------------

1) Gnome started using g-s-d for switching on/off Airplane mode. We will follow that. Hence rfkill related code was removed from cc-network-panel.c. See https://bugzilla.gnome.org/show_bug.cgi?id=703411 and https://github.com/GNOME/gnome-control-center/commit/085e7695133ae482cfbba78ab151a90a3960052d

2) In g-c-c new VPN connections are created within the control center from 8a52138cf6e31d1030ea2829acb6ec96892a8d8c and other types
currently hit the nm-connection-editor fallback. We are doing the same here. For vpn & otype of conection it will simply fall back using nm-connection-editor See https://bugzilla.gnome.org/show_bug.cgi?id=674498 and https://github.com/GNOME/gnome-control-center/commit/8a52138cf6e31d1030ea2829acb6ec96892a8d8c

3) This also includes support for the 'ModemManager1' interface. See https://github.com/GNOME/gnome-control-center/commit/0225d1a9e73cf741f627d595925abb7e886164be
-- 
The attached diff has been truncated due to its size.
Your team Unity Control Center development team is subscribed to branch lp:unity-control-center.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 524288 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-desktop/attachments/20190501/901abb29/attachment-0001.diff>


More information about the ubuntu-desktop mailing list