[Merge] ~alfonsosanchezbeato/network-manager:add-connectivity-check into network-manager:snap-1.10

[Alfonso Sanchez-Beato]

@Tony, thanks for the review! See my comments below.

Diff comments:

> diff --git a/snap/hooks/install b/snap/hooks/install
> deleted file mode 100755
> index 8f4e7ca..0000000
> --- a/snap/hooks/install
> +++ /dev/null
> @@ -1,11 +0,0 @@
> -#!/bin/sh -e

Why do we want to prevent installation on classic? The snap seems to work fine in that case, and imho we should leave the door open for installations in classic for experimentation/testing purposes. I think that the chances of a user installing the snap by mistake in classic are really low.

> -
> -. "$SNAP"/meta/hooks/utils.sh
> -
> -target=$(get_target_system)
> -
> -if [ "$target" != "18" ] ; then
> -    echo "This snap is only supported on Ubuntu Core 18."
> -    exit 1
> -fi
> -
> diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
> index e43dea0..d9e1363 100644
> --- a/snap/snapcraft.yaml
> +++ b/snap/snapcraft.yaml
> @@ -85,7 +80,6 @@ parts:
>    networkmanager:
>      plugin: autotools
>      source: .
> -    build-attributes: [no-system-libraries]

It has been obsoleted in snapcraft 3.0.1, so it was breaking the build for me. Note that 3.0.1 is already in the stable channel.

>      build-packages:
>        - intltool
>        - libdbus-glib-1-dev


-- 
https://code.launchpad.net/~alfonsosanchezbeato/network-manager/+git/network-manager/+merge/361245
Your team Network-manager is requested to review the proposed merge of ~alfonsosanchezbeato/network-manager:add-connectivity-check into network-manager:snap-1.10.